Merge pull request kubernetes-sigs#288 from mengqiy/eagerlygencert

🐛 gen cert for the server even there are no webhooks

Author: k8s-ci-robot

pkg/webhook/internal/cert/provisioner.go

@@ -56,10 +56,6 @@ func (cp *Provisioner) Provision(options Options) (bool, error) {
 	if cp.CertWriter == nil {
 		return false, errors.New("CertWriter need to be set")
 	}
-	// If the objects need to be updated, just be lazy and return.
-	if len(options.Objects) == 0 {
-		return false, nil
-	}
 
 	dnsName, err := dnsNameFromClientConfig(options.ClientConfig)
 	if err != nil {

pkg/webhook/internal/cert/provisioner_test.go

@@ -40,11 +40,18 @@ var _ = Describe("provisioner", func() {
 		It("should return no error", func() {
 			fcw := &fakeCertWriter{}
 			p := Provisioner{CertWriter: fcw}
-			changed, err := p.Provision(Options{})
+			changed, err := p.Provision(Options{
+				ClientConfig: &admissionregistrationv1beta1.WebhookClientConfig{
+					Service: &admissionregistrationv1beta1.ServiceReference{
+						Namespace: "test-svc-namespace",
+						Name:      "test-service",
+					},
+				},
+			})
 			Expect(err).NotTo(HaveOccurred())
-			Expect(changed).To(BeFalse())
-			Expect(fcw.invokedEnsureCert).To(BeFalse())
-			Expect(fcw.invokedInject).To(BeFalse())
+			Expect(changed).To(BeTrue())
+			Expect(fcw.invokedEnsureCert).To(BeTrue())
+			Expect(fcw.invokedInject).To(BeTrue())
 		})
 	})