Skip to content

Commit 5b50300

Browse files
ltfschoenukint-vs
authored andcommitted
fix: Fixes paritytech#13071 change order of ldd command and update ./docker/README.md (paritytech#13072)
* fixes paritytech#13071 * remove warning
1 parent 484ca1b commit 5b50300

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

docker/README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Substrate Builder Docker Image
22

3-
The Docker image in this folder is a `builder` image. It is self contained and allow users to build the binaries themselves.
3+
The Docker image in this folder is a `builder` image. It is self contained and allows users to build the binaries themselves.
44
There is no requirement on having Rust or any other toolchain installed but a working Docker environment.
55

66
Unlike the `parity/polkadot` image which contains a single binary (`polkadot`!) used by default, the image in this folder builds and contains several binaries and you need to provide the name of the binary to be called.
@@ -12,6 +12,11 @@ You should refer to the .Dockerfile for the actual list. At the time of editing,
1212
- node-template
1313
- chain-spec-builder
1414

15+
To generate the latest parity/substrate image. Please first run:
16+
```sh
17+
./build.sh
18+
```
19+
1520
The image can be used by passing the selected binary followed by the appropriate tags for this binary.
1621

1722
Your best guess to get started is to pass the `--help flag`. Here are a few examples:

docker/substrate_builder.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ RUN useradd -m -u 1000 -U -s /bin/sh -d /substrate substrate && \
2424
mkdir -p /data /substrate/.local/share/substrate && \
2525
chown -R substrate:substrate /data && \
2626
ln -s /data /substrate/.local/share/substrate && \
27-
# unclutter and minimize the attack surface
28-
rm -rf /usr/bin /usr/sbin && \
2927
# Sanity checks
3028
ldd /usr/local/bin/substrate && \
29+
# unclutter and minimize the attack surface
30+
rm -rf /usr/bin /usr/sbin && \
3131
/usr/local/bin/substrate --version
3232

3333
USER substrate

0 commit comments

Comments
 (0)