From 35527dff6a2e6972eaaa7316c27a96f5f3927247 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yoshioka=20Tsuneo=20=28=E5=90=89=E5=B2=A1=20=E6=81=92?= =?UTF-8?q?=E5=A4=AB=29?= Date: Tue, 9 Dec 2025 22:33:41 +0900 Subject: [PATCH 1/2] execute button shortcut: command+enter instead of mod+enter --- client/app/pages/queries/QuerySource.jsx | 2 +- client/app/pages/queries/QueryView.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/app/pages/queries/QuerySource.jsx b/client/app/pages/queries/QuerySource.jsx index f492b99324..ad1972184b 100644 --- a/client/app/pages/queries/QuerySource.jsx +++ b/client/app/pages/queries/QuerySource.jsx @@ -297,7 +297,7 @@ function QuerySource(props) { } executeButtonProps={{ disabled: !queryFlags.canExecute || isQueryExecuting || areParametersDirty, - shortcut: "mod+enter, alt+enter, ctrl+enter, shift+enter", + shortcut: "command+enter, alt+enter, ctrl+enter, shift+enter", onClick: doExecuteQuery, text: ( {selectedText === null ? "Execute" : "Execute Selected"} diff --git a/client/app/pages/queries/QueryView.jsx b/client/app/pages/queries/QueryView.jsx index cbd582b480..8d59f5ca09 100644 --- a/client/app/pages/queries/QueryView.jsx +++ b/client/app/pages/queries/QueryView.jsx @@ -110,7 +110,7 @@ function QueryView(props) { Refresh From 81893cec4706757fb85b5f560e89a464813994df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yoshioka=20Tsuneo=20=28=E5=90=89=E5=B2=A1=20=E6=81=92?= =?UTF-8?q?=E5=A4=AB=29?= Date: Tue, 9 Dec 2025 22:42:41 +0900 Subject: [PATCH 2/2] restyle by pretteier --- client/app/pages/queries/QuerySource.jsx | 26 +++++++++++++----------- client/app/pages/queries/QueryView.jsx | 16 +++++++++------ 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/client/app/pages/queries/QuerySource.jsx b/client/app/pages/queries/QuerySource.jsx index ad1972184b..1c3bce90fb 100644 --- a/client/app/pages/queries/QuerySource.jsx +++ b/client/app/pages/queries/QuerySource.jsx @@ -47,8 +47,8 @@ import "./components/QuerySourceDropdown"; // register QuerySourceDropdown import "./QuerySource.less"; function chooseDataSourceId(dataSourceIds, availableDataSources) { - availableDataSources = map(availableDataSources, ds => ds.id); - return find(dataSourceIds, id => includes(availableDataSources, id)) || null; + availableDataSources = map(availableDataSources, (ds) => ds.id); + return find(dataSourceIds, (id) => includes(availableDataSources, id)) || null; } function QuerySource(props) { @@ -81,7 +81,7 @@ function QuerySource(props) { const [autocompleteAvailable, autocompleteEnabled, toggleAutocomplete] = useAutocompleteFlags(schema); const [autoLimitAvailable, autoLimitChecked, setAutoLimit] = useAutoLimitFlags(dataSource, query, setQuery); - const [handleQueryEditorChange] = useDebouncedCallback(queryText => { + const [handleQueryEditorChange] = useDebouncedCallback((queryText) => { setQuery(extend(query.clone(), { query: queryText })); }, 100); @@ -108,7 +108,7 @@ function QuerySource(props) { }; const handleDataSourceChange = useCallback( - dataSourceId => { + (dataSourceId) => { if (dataSourceId) { try { localStorage.setItem("lastSelectedDataSourceId", dataSourceId); @@ -151,7 +151,7 @@ function QuerySource(props) { setQuery(newQuery); }); - const handleSchemaItemSelect = useCallback(schemaItem => { + const handleSchemaItemSelect = useCallback((schemaItem) => { if (editorRef.current) { editorRef.current.paste(schemaItem); } @@ -188,7 +188,7 @@ function QuerySource(props) { setQuery(newQuery); setSelectedVisualization(visualization.id); }); - const editVisualization = useEditVisualizationDialog(query, queryResult, newQuery => setQuery(newQuery)); + const editVisualization = useEditVisualizationDialog(query, queryResult, (newQuery) => setQuery(newQuery)); const deleteVisualization = useDeleteVisualization(query, setQuery); return ( @@ -223,7 +223,7 @@ function QuerySource(props) { + onOptionsUpdate={(schemaOptions) => setQuery(extend(query.clone(), { options: { ...query.options, schemaOptions } })) } onSchemaUpdate={setSchema} @@ -253,7 +253,8 @@ function QuerySource(props) {
+ style={{ left: 0, top: 0, right: 0, bottom: 0, overflow: "auto" }} + >
@@ -319,7 +320,7 @@ function QuerySource(props) { disabled: !queryFlags.canEdit, value: dataSource.id, onChange: handleDataSourceChange, - options: map(dataSources, ds => ({ value: ds.id, label: ds.name })), + options: map(dataSources, (ds) => ({ value: ds.id, label: ds.name })), } : false } @@ -391,7 +392,8 @@ function QuerySource(props) { type="primary" disabled={!queryFlags.canExecute || areParametersDirty} loading={isQueryExecuting} - onClick={doExecuteQuery}> + onClick={doExecuteQuery} + > {!isQueryExecuting &&