Makes origin field private

Author: antonis

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 ### Features
 
-- Added breadcrumb.origin field (#4358)
+- Added breadcrumb.origin private field (#4358)
 - Custom redact modifier for SwiftUI (#4362)
 
 ### Improvements

Sources/Sentry/Public/SentryBreadcrumb.h

@@ -34,12 +34,6 @@ NS_SWIFT_NAME(Breadcrumb)
  */
 @property (nonatomic, copy, nullable) NSString *type;
 
-/**
- * Origin of the breadcrumb that is used to identify source of the breadcrumb
- * For example hybrid SDKs can identify native breadcrumbs from JS or Flutter
- */
-@property (nonatomic, copy, nullable) NSString *origin;
-
 /**
  * Message for the breadcrumb
  */

Sources/Sentry/SentryBreadcrumb.m

@@ -1,4 +1,5 @@
 #import "SentryBreadcrumb.h"
+#import "SentryBreadcrumb+Private.h"
 #import "SentryDateUtils.h"
 #import "SentryLevelMapper.h"
 #import "SentryNSDictionarySanitize.h"

Sources/Sentry/SentryCrashReportConverter.m

@@ -1,4 +1,5 @@
 #import "SentryCrashReportConverter.h"
+#import "SentryBreadcrumb+Private.h"
 #import "SentryBreadcrumb.h"
 #import "SentryCrashStackCursor.h"
 #import "SentryDateUtils.h"

Sources/Sentry/include/HybridPublic/SentryBreadcrumb+Private.h

@@ -2,10 +2,16 @@
 
 @interface SentryBreadcrumb ()
 
+/**
+ * Origin of the breadcrumb that is used to identify source of the breadcrumb
+ * For example hybrid SDKs can identify native breadcrumbs from JS or Flutter
+ */
+@property (nonatomic, copy, nullable) NSString *origin;
+
 /**
  * Initializes a SentryBreadcrumb from a JSON object.
  * @param dictionary The dictionary containing breadcrumb data.
  * @return The SentryBreadcrumb.
  */
-- (instancetype)initWithDictionary:(NSDictionary *)dictionary;
+- (instancetype _Nonnull)initWithDictionary:(NSDictionary *_Nonnull)dictionary;
 @end

Tests/SentryTests/SentryInterfacesTests.m

@@ -1,5 +1,6 @@
 #import <XCTest/XCTest.h>
 
+#import "SentryBreadcrumb+Private.h"
 #import "SentryBreadcrumb.h"
 #import "SentryDateUtils.h"
 #import "SentryEvent.h"

Tests/SentryTests/SentryTests-Bridging-Header.h

@@ -58,6 +58,7 @@
 #import "SentryAutoBreadcrumbTrackingIntegration.h"
 #import "SentryAutoSessionTrackingIntegration.h"
 #import "SentryBooleanSerialization.h"
+#import "SentryBreadcrumb+Private.h"
 #import "SentryBreadcrumbDelegate.h"
 #import "SentryBreadcrumbTracker.h"
 #import "SentryByteCountFormatter.h"

Tests/SentryTests/SentryTests.m

@@ -10,6 +10,7 @@
 #import "SentryMeta.h"
 #import "SentryOptions+HybridSDKs.h"
 #import "SentrySDK+Private.h"
+#import <SentryBreadcrumb+Private.h>
 #import <XCTest/XCTest.h>
 @import Sentry;