diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 94f1b74339..f12f4ecc90 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -37,7 +37,7 @@ jobs: - uses: actions/checkout@v2 - run: pub get - name: Test on Chrome - run: pub run test -p chrome test/* + run: pub run test -p chrome test - run: dartanalyzer --fatal-warnings ./ - run: dartfmt -n --set-exit-if-changed ./ package-analysis: diff --git a/CHANGELOG.md b/CHANGELOG.md index bf86df0b03..b313feb811 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ - new Dart code file structure #96 - Base the sdk name on the platform (`sentry.dart` for io & flutter, `sentry.dart.browser` in a browser context) #103 - Single changelog and readme for both packages #105 +- expect a sdkName based on the test platform #105 # `package:sentry` changelog diff --git a/dart/test/test_utils.dart b/dart/test/test_utils.dart index 9eb48b6e07..ecc0c676db 100644 --- a/dart/test/test_utils.dart +++ b/dart/test/test_utils.dart @@ -20,6 +20,7 @@ const String _testDsnWithPort = void testHeaders( Map headers, ClockProvider fakeClockProvider, { + String sdkName, bool withUserAgent = true, bool compressPayload = true, bool withSecret = true, @@ -98,6 +99,7 @@ Future testCaptureException( fakeClockProvider, compressPayload: compressPayload, withUserAgent: !isWeb, + sdkName: isWeb ? browserSdkName : sdkName, ); Map data; @@ -256,6 +258,7 @@ void runTest({Codec, List> gzip, bool isWeb = false}) { withUserAgent: !isWeb, compressPayload: false, withSecret: false, + sdkName: isWeb ? browserSdkName : sdkName, ); await client.close();