From ddbf55d2bddb1f311e116c56ff9f94a630d40a61 Mon Sep 17 00:00:00 2001 From: Jan Michael Auer Date: Wed, 11 Jul 2018 10:17:01 +0200 Subject: [PATCH 1/2] fix(minidump): Recommend to turn off gzip for crashpad --- docs/clients/minidump/crashpad.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/clients/minidump/crashpad.rst b/docs/clients/minidump/crashpad.rst index cb2aaace4ebe5..178f38eb4cda3 100644 --- a/docs/clients/minidump/crashpad.rst +++ b/docs/clients/minidump/crashpad.rst @@ -58,6 +58,14 @@ platforms, child processes must also register by using `SetHandlerIPCPipe()`_. For more information on configuring the crashpad handler, see `crashpad_handler`_. +.. admonition:: Known Issue + + Sentry cannot handle gzip compressed minidump submissions and will respond + with a 400 error. To fix this, pass the ``--no-upload-gzip`` argument to the + handler:: + + arguments.push_back("--no-upload-gzip"); + If you also want Crashpad to upload crashes to Sentry, additionally configure the Crashpad database for automatic uploads: From 708bdc0ac615cc64a89d71849f62bee7a010c40f Mon Sep 17 00:00:00 2001 From: Jan Michael Auer Date: Wed, 11 Jul 2018 10:35:03 +0200 Subject: [PATCH 2/2] fix(minidump): Add a disclaimer on rate limiting --- docs/clients/minidump/crashpad.rst | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/clients/minidump/crashpad.rst b/docs/clients/minidump/crashpad.rst index 178f38eb4cda3..4f63683bc0cec 100644 --- a/docs/clients/minidump/crashpad.rst +++ b/docs/clients/minidump/crashpad.rst @@ -62,7 +62,9 @@ For more information on configuring the crashpad handler, see Sentry cannot handle gzip compressed minidump submissions and will respond with a 400 error. To fix this, pass the ``--no-upload-gzip`` argument to the - handler:: + handler: + + .. code-block:: cpp arguments.push_back("--no-upload-gzip"); @@ -81,6 +83,13 @@ the Crashpad database for automatic uploads: db->GetSettings()->SetUploadsEnabled(true); } +By default, the crashpad handler will limit uploads to one per hour. To disable +this limitation, pass the ``--no-rate-limit`` argument to the handler: + +.. code-block:: cpp + + arguments.push_back("--no-rate-limit"); + .. _Crashpad: https://chromium.googlesource.com/crashpad/crashpad/+/master/README.md .. _Developing Crashpad: https://chromium.googlesource.com/crashpad/crashpad/+/HEAD/doc/developing.md .. _StartHandler(): https://crashpad.chromium.org/doxygen/classcrashpad_1_1CrashpadClient.html#a810ad9941bedba543bf60507c31c55da