fix: Support for CaptureFailedRequests on iOS#2826
Merged
bitsandfoxes merged 1 commit intogetsentry:mainfrom Nov 13, 2023
Merged
fix: Support for CaptureFailedRequests on iOS#2826bitsandfoxes merged 1 commit intogetsentry:mainfrom
bitsandfoxes merged 1 commit intogetsentry:mainfrom
Conversation
Fixes getsentry#2744 Setting either `CaptureFailedRequests` or `FailedRequestStatusCodes` previously only affected the .NET layer and was not passed to sentry-cocoa. In production, this meant that failed requests were being tracked despite the setting being set to false.
carmichaelalonso
requested review from
bitsandfoxes and
jamescrosswell
as code owners
bitsandfoxes
approved these changes
Nov 13, 2023
Contributor
|
This looks great, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2744
Setting either
CaptureFailedRequestsorFailedRequestStatusCodespreviously only affected the .NET layer and was not passed to sentry-cocoa.In production, this meant that failed requests were being tracked despite the setting being set to false in the .NET layer, which quickly added up in tracked errors on a hosted Sentry plan. This PR ensures we pass this value at init, and properly support failed status code ranges.