From 5ce932a18f14fc8df82c00ff6f1b140b85cd29d4 Mon Sep 17 00:00:00 2001 From: bricefriha Date: Mon, 11 Nov 2024 16:10:39 +0000 Subject: [PATCH 1/5] Sentry.Nlog -| upgrade NLog to 5.3.4 --- src/Sentry.NLog/Sentry.NLog.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Sentry.NLog/Sentry.NLog.csproj b/src/Sentry.NLog/Sentry.NLog.csproj index 134d0ff7b6..d0bd93b946 100644 --- a/src/Sentry.NLog/Sentry.NLog.csproj +++ b/src/Sentry.NLog/Sentry.NLog.csproj @@ -12,7 +12,7 @@ - + From e812dcfa6ec315e896614549d71a1bb92c6d2ecc Mon Sep 17 00:00:00 2001 From: bricefriha Date: Mon, 11 Nov 2024 16:20:52 +0000 Subject: [PATCH 2/5] Nlog - Android Trimming issue | Add RegisterType SentryNLogOptions in the Setup Extensions of the LogManager to prevent NLog types form getting trimmed --- src/Sentry.NLog/ConfigurationExtensions.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Sentry.NLog/ConfigurationExtensions.cs b/src/Sentry.NLog/ConfigurationExtensions.cs index c58ad24baa..596fb9bca0 100644 --- a/src/Sentry.NLog/ConfigurationExtensions.cs +++ b/src/Sentry.NLog/ConfigurationExtensions.cs @@ -83,7 +83,11 @@ public static LoggingConfiguration AddSentry( optionsConfig?.Invoke(options); - LogManager.Setup().SetupExtensions(e => e.RegisterTarget("Sentry")); + LogManager.Setup().SetupExtensions(e => + { + e.RegisterTarget("Sentry"); + e.RegisterType(); + }); var target = new SentryTarget(options) { From 901c7ed55af67b79d34e057c132edd3c947251bf Mon Sep 17 00:00:00 2001 From: bricefriha Date: Mon, 11 Nov 2024 16:33:02 +0000 Subject: [PATCH 3/5] Changelog | add entry for #3743 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3027d43a88..b9c09ef5be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Fixes + +- fixed issue that causes a crash when using NLog with FailedRequestStatusCodes options in a Maui app with Trimming enabled ([#3743](https://github.com/getsentry/sentry-dotnet/pull/3743)) + ### Dependencies - Bump Cocoa SDK from v8.36.0 to v8.39.0 ([#3727](https://github.com/getsentry/sentry-dotnet/pull/3727)) From 042a0f4adf835f5070d2c830f59c1d6105fd6c66 Mon Sep 17 00:00:00 2001 From: bricefriha Date: Mon, 11 Nov 2024 16:48:30 +0000 Subject: [PATCH 4/5] NLog - tests | update Nlog --- src/Sentry.NLog/Sentry.NLog.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Sentry.NLog/Sentry.NLog.csproj b/src/Sentry.NLog/Sentry.NLog.csproj index d0bd93b946..09ce5b7b75 100644 --- a/src/Sentry.NLog/Sentry.NLog.csproj +++ b/src/Sentry.NLog/Sentry.NLog.csproj @@ -12,7 +12,7 @@ - + From 11a0971bdfa21d7800f36127a9d9445e8034f92f Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Sat, 16 Nov 2024 21:18:28 +1300 Subject: [PATCH 5/5] Update action.yml --- .github/actions/environment/action.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/actions/environment/action.yml b/.github/actions/environment/action.yml index ac61ac303b..b18a49d3cf 100644 --- a/.github/actions/environment/action.yml +++ b/.github/actions/environment/action.yml @@ -50,7 +50,6 @@ runs: brew link --overwrite mono - name: Install .NET SDK - if: runner.os != 'Windows' uses: actions/setup-dotnet@v3 with: dotnet-version: |