From 93acc92c71297843ebc2f66ffd50230c729ef72c Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Thu, 3 Apr 2025 19:18:13 +1300 Subject: [PATCH 1/6] Detect Sentry Java SDK dependencies during build --- .../Sentry.Bindings.Android.csproj | 30 ++++--------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj index b9aec99266..91cb56f1e1 100644 --- a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj +++ b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj @@ -1,6 +1,6 @@ - net8.0-android34.0 + net8.0-android34.0;net9.0-android35.0; $(NoWarn);BG8605;BG8606 7.20.1 @@ -30,9 +30,10 @@ - - - + + + + @@ -40,25 +41,4 @@ - - - - - - From 7809cc8d0b4a2d97c89edce20838000c1dca02e0 Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Thu, 3 Apr 2025 19:40:16 +1300 Subject: [PATCH 2/6] Added missing Java dependencies --- src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj index 91cb56f1e1..3c863ec6f7 100644 --- a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj +++ b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj @@ -19,6 +19,11 @@ + + + + + From f1bc8776ac0d2cf932f6a4846433cf5c31b0938c Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Thu, 3 Apr 2025 19:52:21 +1300 Subject: [PATCH 3/6] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e3dd61e5aa..99477c91ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -563,6 +563,7 @@ Unable to load DLL sentry-native or one of its dependencies ### Fixes - Dynamic Sampling Context not propagated correctly for HttpClient spans ([#3208](https://github.com/getsentry/sentry-dotnet/pull/3208)) +- Sentry Java SDK dependencies are now detected and included in the Android bindings ([#4079](https://github.com/getsentry/sentry-dotnet/pull/4079)) ## 4.2.0 From 5a1e885ec9fb727af86ed22d267e152c8e30292b Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Thu, 3 Apr 2025 19:54:56 +1300 Subject: [PATCH 4/6] Update CHANGELOG.md --- CHANGELOG.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 99477c91ac..8e7c6f7bec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Fixes + +- Sentry Java SDK dependencies are now detected and included in the Android bindings ([#4079](https://github.com/getsentry/sentry-dotnet/pull/4079)) + ## 5.5.0 ### Features @@ -563,7 +569,6 @@ Unable to load DLL sentry-native or one of its dependencies ### Fixes - Dynamic Sampling Context not propagated correctly for HttpClient spans ([#3208](https://github.com/getsentry/sentry-dotnet/pull/3208)) -- Sentry Java SDK dependencies are now detected and included in the Android bindings ([#4079](https://github.com/getsentry/sentry-dotnet/pull/4079)) ## 4.2.0 From 07e6076df2e9c43be89931c674d0ca5d281055eb Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Fri, 4 Apr 2025 16:52:24 +1300 Subject: [PATCH 5/6] Update Sentry.Bindings.Android.csproj --- .../Sentry.Bindings.Android.csproj | 23 +++++++++++++++---- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj index 3c863ec6f7..4c445bd779 100644 --- a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj +++ b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj @@ -1,6 +1,6 @@ - net8.0-android34.0;net9.0-android35.0; + net8.0-android34.0;net9.0-android35.0 $(NoWarn);BG8605;BG8606 7.20.1 @@ -19,11 +19,24 @@ + + + + + + + + + + - - - - + + + + + + + From c84f27d2549d23c9a3bfa22cc9d51623de8b9642 Mon Sep 17 00:00:00 2001 From: James Crosswell Date: Fri, 4 Apr 2025 18:52:56 +1300 Subject: [PATCH 6/6] Update Sentry.Bindings.Android.csproj --- .../Sentry.Bindings.Android.csproj | 49 +++++++++++++++++-- 1 file changed, 44 insertions(+), 5 deletions(-) diff --git a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj index 4c445bd779..a5b484d938 100644 --- a/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj +++ b/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj @@ -1,10 +1,9 @@ + net8.0-android34.0;net9.0-android35.0 - - $(NoWarn);BG8605;BG8606 7.20.1 - $(BaseIntermediateOutputPath)sdks\Sentry\Android\$(SentryAndroidSdkVersion)\ + $(BaseIntermediateOutputPath)sdks\$(TargetFramework)\Sentry\Android\$(SentryAndroidSdkVersion)\ .NET Bindings for the Sentry Android SDK @@ -47,11 +46,24 @@ - + + + + + + + - + + + + @@ -59,4 +71,31 @@ + + + + + + +