From 3e1beece3c7c266c709f49397a10cc6aac5d2192 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Tue, 5 Aug 2025 14:21:58 +0200 Subject: [PATCH 1/7] fix: version Sentry-Dynamic.xcframework --- .../Sentry.Bindings.Cocoa.csproj | 27 +++++++++---------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj index 60364aae34..b6e21851e8 100644 --- a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj +++ b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj @@ -7,9 +7,11 @@ true true .NET Bindings for the Sentry Cocoa SDK - ..\..\modules\sentry-cocoa\ + $(MSBuildThisFileDirectory)..\..\modules\sentry-cocoa\ $(SentryCocoaCache)Sentry.framework\ - $(SentryCocoaCache)Sentry-Dynamic.xcframework + $([System.IO.File]::ReadAllText("$(MSBuildThisFileDirectory)../../modules/sentry-cocoa.properties")) + $([System.Text.RegularExpressions.Regex]::Match($(SentryCocoaProperties), 'version\s*=\s*([^\s]+)').Groups[1].Value) + $(SentryCocoaCache)Sentry-$(SentryCocoaVersion).xcframework @@ -47,19 +49,14 @@ - - $([System.IO.File]::ReadAllText("../../modules/sentry-cocoa.properties")) - $([System.Text.RegularExpressions.Regex]::Match($(PropertiesContent), 'version\s*=\s*([^\s]+)').Groups[1].Value) - - - + @@ -67,17 +64,17 @@ + Condition="!Exists('$(SentryCocoaFramework).zip')" + Command="curl -L https://github.com/getsentry/sentry-cocoa/releases/download/$(SentryCocoaVersion)/Sentry-Dynamic.xcframework.zip -o $(SentryCocoaFramework).zip" /> + Condition="Exists('$(SentryCocoaFramework).zip') and !Exists('$(SentryCocoaFramework)')" + Command="unzip -o $(SentryCocoaFramework).zip -d $(SentryCocoaCache) && mv $(SentryCocoaCache)Sentry-Dynamic.xcframework $(SentryCocoaFramework)" /> - + Date: Tue, 5 Aug 2025 16:56:09 +0200 Subject: [PATCH 2/7] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 11f2237078..1fe1198bb9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - Update `sample_rate` of _Dynamic Sampling Context (DSC)_ when making sampling decisions ([#4374](https://github.com/getsentry/sentry-dotnet/pull/4374)) +- Ensure the correct Sentry Cocoa SDK framework version is used on iOS ([#4411](https://github.com/getsentry/sentry-dotnet/pull/4411)) ## 5.13.0 From 5fb163398335ca16a38120e4ef77ef0b7a4dff6b Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Tue, 5 Aug 2025 17:29:03 +0200 Subject: [PATCH 3/7] Setup exactly once --- .../Sentry.Bindings.Cocoa.csproj | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj index b6e21851e8..aac1ba0521 100644 --- a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj +++ b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj @@ -7,7 +7,7 @@ true true .NET Bindings for the Sentry Cocoa SDK - $(MSBuildThisFileDirectory)..\..\modules\sentry-cocoa\ + ..\..\modules\sentry-cocoa\ $(SentryCocoaCache)Sentry.framework\ $([System.IO.File]::ReadAllText("$(MSBuildThisFileDirectory)../../modules/sentry-cocoa.properties")) $([System.Text.RegularExpressions.Regex]::Match($(SentryCocoaProperties), 'version\s*=\s*([^\s]+)').Groups[1].Value) @@ -48,9 +48,7 @@ - + @@ -81,6 +79,18 @@ SkipUnchangedFiles="true" /> + + + + + + + + From 10eec203d1feced9f7e64248e1b75a05fddea0de Mon Sep 17 00:00:00 2001 From: getsentry-bot Date: Tue, 5 Aug 2025 20:39:43 +0000 Subject: [PATCH 4/7] release: 5.14.0-alpha.0 --- CHANGELOG.md | 2 +- Directory.Build.props | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1fe1198bb9..935ae3cfa9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## Unreleased +## 5.14.0-alpha.0 ### Fixes diff --git a/Directory.Build.props b/Directory.Build.props index 2f2a0020ce..4d7764455b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,7 +1,7 @@ - 5.13.0 + 5.14.0-alpha.0 13 true true From c25952a523d5a67c50c6bd712420523e16430861 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Wed, 6 Aug 2025 08:02:41 +0200 Subject: [PATCH 5/7] Restore condition for inner _SetupCocoaSDK --- src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj index aac1ba0521..b7192a703e 100644 --- a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj +++ b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj @@ -48,7 +48,8 @@ - + From c25ceec1a727a03508aeabb88de448e3260ccfbd Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Thu, 7 Aug 2025 11:09:42 +0200 Subject: [PATCH 6/7] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com> --- src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj index b7192a703e..5d175c990b 100644 --- a/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj +++ b/src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj @@ -80,7 +80,7 @@ SkipUnchangedFiles="true" /> - + @@ -88,7 +88,7 @@ - + From 55b11b1f8b4d66f666667a2c2b27ffc6929a4e50 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Mon, 11 Aug 2025 10:52:02 +0200 Subject: [PATCH 7/7] Fix CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 75b2eeb40c..14c7c47035 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ ### Fixes - Crontabs now support day names (MON-SUN) and allow step values and ranges to be combined ([#4407](https://github.com/getsentry/sentry-dotnet/pull/4407)) +- Ensure the correct Sentry Cocoa SDK framework version is used on iOS ([#4411](https://github.com/getsentry/sentry-dotnet/pull/4411)) ### Dependencies @@ -24,7 +25,6 @@ ### Fixes - Update `sample_rate` of _Dynamic Sampling Context (DSC)_ when making sampling decisions ([#4374](https://github.com/getsentry/sentry-dotnet/pull/4374)) -- Ensure the correct Sentry Cocoa SDK framework version is used on iOS ([#4411](https://github.com/getsentry/sentry-dotnet/pull/4411)) ## 5.13.0