Skip to content

fix: Pass correct event to beforeSend #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2022
Merged

fix: Pass correct event to beforeSend #484

merged 1 commit into from
May 15, 2022

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented May 11, 2022

Fixes #481

@timfish
Copy link
Collaborator Author

timfish commented May 11, 2022

I would normally add a test for this but once #471 is merged in, we'll be going through beforeSend and sampleRate in @sentry/core so much of this code can go.

@timfish timfish merged commit d7e040b into getsentry:master May 15, 2022
@timfish timfish mentioned this pull request Jun 20, 2022
Merged
@timfish timfish deleted the fix/native-crash-beforesend branch July 25, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SentryMinidump: native crash report does not contain expected scope / context if a beforeSend function is supplied

2 participants

@timfish @AbhiPrasad