ref: PR feedback

Author: mydea

packages/replay/src/replay.ts

@@ -185,7 +185,10 @@ export class ReplayContainer {
     try {
       this._stopRecording = record({
         ...this.recordingOptions,
-        ...this._getRecordingOptionsOverwrites(),
+        // When running in error sampling mode, we need to overwrite `checkoutEveryNth`
+        // Without this, it would record forever, until an error happens, which we don't want
+        // instead, we'll always keep the last 60 seconds of replay before an error happened
+        ...(this._waitForError && { checkoutEveryNth: 60000 }),
         emit: this.handleRecordingEmit,
       });
     } catch (err) {
@@ -1281,16 +1284,4 @@ export class ReplayContainer {
 
     client.recordDroppedEvent = this._originalRecordDroppedEvent;
   }
-
-  /** Additional recordingOptions that should take precedence over user config */
-  private _getRecordingOptionsOverwrites(): Partial<RecordingOptions> {
-    return this._waitForError
-      ? {
-          // Checkout every minute, meaning we only get up-to one minute of events before the error happens
-          // Without this, it would record forever, until an error happens, which we don't want
-          // instead, we'll always keep the last 60 seconds of replay before an error happened
-          checkoutEveryNth: 60000,
-        }
-      : {};
-  }
 }