fix: Make sure that error is present before logging it in Vue #3183
Conversation
size-limit report
|
| if (this._options.logErrors) { | ||
| if (this._options.Vue.util) { | ||
| this._options.Vue.util.warn(`Error in ${info}: "${error.toString()}"`, vm); | ||
| this._options.Vue.util.warn(`Error in ${info}: "${error && error.toString()}"`, vm); |
There was a problem hiding this comment.
I don't know Vue, but will there ever be info if there is no error? What about vm?
In any case, it might be nice to provide the user with the information that the error is null rather than just now showing anything. That way, they know it's not the reporting that's broken.
| this._options.Vue.util.warn(`Error in ${info}: "${error && error.toString()}"`, vm); | |
| this._options.Vue.util.warn(`Error in ${info}: "${error && error.toString() || 'null'}"`, vm); |
There was a problem hiding this comment.
Error in foo: null
Looks strange to me, why would there be a warning in the first place.
There was a problem hiding this comment.
Worse than Error in foo:, though? The dangling colon feels wrong to me.
Maybe Error in foo: <null> is better?
|
Since this was a bug, could we add a corresponding test case? Ok to do it in a follow up if you want to ship this timely. |
|
Will do that @rhcarvalho, just wanted to make sure it's unblocked for some people. |
Fixes #3178