Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(eventprocessors): Add name field to EventProcessor
  • Loading branch information
Luca Forstner committed Apr 13, 2022
commit b5eafa63ce4441f02b3e303486ce81fed80da212
16 changes: 15 additions & 1 deletion packages/hub/src/scope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,17 @@ import {
Transaction,
User,
} from '@sentry/types';
import { dateTimestampInSeconds, getGlobalSingleton, isPlainObject, isThenable, SyncPromise } from '@sentry/utils';
import {
dateTimestampInSeconds,
getGlobalSingleton,
isPlainObject,
isThenable,
SyncPromise,
logger,
} from '@sentry/utils';

import { Session } from './session';
import { IS_DEBUG_BUILD } from './flags';

/**
* Absolute maximum number of breadcrumbs added to an event.
Expand Down Expand Up @@ -457,6 +465,12 @@ export class Scope implements ScopeInterface {
resolve(event);
} else {
const result = processor({ ...event }, hint) as Event | null;

IS_DEBUG_BUILD &&
processor.name &&
result === null &&
logger.log(`Event processor ${processor.name} dropped event.`);

if (isThenable(result)) {
void result
.then(final => this._notifyEventProcessors(processors, final, hint, index + 1).then(resolve))
Expand Down
5 changes: 4 additions & 1 deletion packages/types/src/eventprocessor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ import { Event, EventHint } from './event';
* Returning a PromiseLike<Event | null> will work just fine, but better be sure that you know what you are doing.
* Event processing will be deferred until your Promise is resolved.
*/
export type EventProcessor = (event: Event, hint?: EventHint) => PromiseLike<Event | null> | Event | null;
export interface EventProcessor {
name?: string;
(event: Event, hint?: EventHint): PromiseLike<Event | null> | Event | null;
}