Skip to content

ref(replay): Extract some functions out from class #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 9, 2022
Merged

ref(replay): Extract some functions out from class #6448

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
737adb2
ref(replay): Extract `overwriteRecordDroppedEvent` into fn
mydea Dec 6, 2022
a558935
ref(replay): Extract span listeners out
mydea Dec 6, 2022
db1ab04
ref(replay): Extract handleGlobalEvent handler out
mydea Dec 6, 2022
edd132a
ref(replay): Fix accidental renaming
mydea Dec 6, 2022
391a22c
ref(replay): Extract performanceObserver out
mydea Dec 6, 2022
229bd51
ref(replay): Make some things public
mydea Dec 6, 2022
721e682
ref(replay): Extract addEvent out
mydea Dec 6, 2022
d7a3e3a
ref(replay): Extract createPerformanceSpans out
mydea Dec 6, 2022
e026241
ref(replay): Extract addMemoryEntry out
mydea Dec 6, 2022
3791c69
doc(replay): Add jsdoc to extracted functions
mydea Dec 7, 2022
37efedb
ref(replay): Only import types for extracted replay functions
mydea Dec 7, 2022
efc9525
build(replay): Skip type imports for circular dependency check
mydea Dec 7, 2022
432da15
ref(replay): PR feedback
mydea Dec 7, 2022
f7caf64
ref(replay): Extract types into `types.ts`
mydea Dec 7, 2022
cf54a67
ref(replay): Make `addMemoryEntry` and `createPerformanceSpans` to sync
mydea Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ref(replay): Fix accidental renaming
  • Loading branch information
@mydea
mydea committed Dec 9, 2022
commit edd132a3ae9ec6b24efd5d0335b9030561580f1f
4 changes: 2 additions & 2 deletions packages/replay/src/replay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export class ReplayContainer {
return;
}

this._performanceObserver = new PerformanceObserver(this.handle_performanceObserver);
this._performanceObserver = new PerformanceObserver(this.handlePerformanceObserver);

// Observe almost everything for now (no mark/measure)
[
Expand Down Expand Up @@ -573,7 +573,7 @@ export class ReplayContainer {
/**
* Keep a list of performance entries that will be sent with a replay
*/
handle_performanceObserver: (list: PerformanceObserverEntryList) => void = (list: PerformanceObserverEntryList) => {
handlePerformanceObserver: (list: PerformanceObserverEntryList) => void = (list: PerformanceObserverEntryList) => {
// For whatever reason the observer was returning duplicate navigation
// entries (the other entry types were not duplicated).
const newPerformanceEntries = dedupePerformanceEntries(
Expand Down