Skip to content

Commit dec9a6e

Browse files
authored
ref(types): decouple profiling filters from DeprecatedSmartSearchBar (#99799)
profiling filters are no longer rendering a DeprecatedSmartSearchBar - they are already rendering the recommended alternative `SearchQueryBuilder`. However, the types are still coupled to DeprecatedSmartSearchBar. The motivation here is to be able to completely remove DeprecatedSmartSearchBar in the near future.
1 parent 9158201 commit dec9a6e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

static/app/views/profiling/content.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import type {Location} from 'history';
55
import Feature from 'sentry/components/acl/feature';
66
import {Alert} from 'sentry/components/core/alert';
77
import {TabList, Tabs} from 'sentry/components/core/tabs';
8-
import type {SmartSearchBarProps} from 'sentry/components/deprecatedSmartSearchBar';
98
import FeedbackWidgetButton from 'sentry/components/feedback/widget/feedbackWidgetButton';
109
import * as Layout from 'sentry/components/layouts/thirds';
1110
import {DatePageFilter} from 'sentry/components/organizations/datePageFilter';
@@ -240,7 +239,7 @@ interface TabbedContentProps extends ProfilingTabProps {
240239

241240
function TransactionsTab({onDataState, location, selection}: TabbedContentProps) {
242241
const query = decodeScalar(location.query.query, '');
243-
const handleSearch: SmartSearchBarProps['onSearch'] = useCallback(
242+
const handleSearch = useCallback(
244243
(searchQuery: string) => {
245244
browserHistory.push({
246245
...location,

static/app/views/profiling/profileSummary/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {SegmentedControl} from 'sentry/components/core/segmentedControl';
1111
import {TabList, Tabs} from 'sentry/components/core/tabs';
1212
import Count from 'sentry/components/count';
1313
import {DateTime} from 'sentry/components/dateTime';
14-
import type {SmartSearchBarProps} from 'sentry/components/deprecatedSmartSearchBar';
1514
import ErrorBoundary from 'sentry/components/errorBoundary';
1615
import FeedbackWidgetButton from 'sentry/components/feedback/widget/feedbackWidgetButton';
1716
import IdBadge from 'sentry/components/idBadge';
@@ -210,7 +209,7 @@ interface ProfileFiltersProps {
210209
}
211210

212211
function ProfileFilters(props: ProfileFiltersProps) {
213-
const handleSearch: SmartSearchBarProps['onSearch'] = useCallback(
212+
const handleSearch = useCallback(
214213
(searchQuery: string) => {
215214
browserHistory.push({
216215
...props.location,

0 commit comments

Comments
 (0)