diff --git a/static/app/components/pageAlertBar.tsx b/static/app/components/pageAlertBar.tsx deleted file mode 100644 index e7ac855d0f7be5..00000000000000 --- a/static/app/components/pageAlertBar.tsx +++ /dev/null @@ -1,13 +0,0 @@ -import styled from '@emotion/styled'; - -const PageAlertBar = styled('div')` - display: flex; - align-items: center; - justify-content: center; - color: ${p => p.theme.headerBackground}; - background-color: ${p => p.theme.bannerBackground}; - padding: 6px 30px; - font-size: 14px; -`; - -export default PageAlertBar; diff --git a/static/app/views/insights/common/components/modulePageFilterBar.tsx b/static/app/views/insights/common/components/modulePageFilterBar.tsx index b9693ac79c5735..640253c4647d53 100644 --- a/static/app/views/insights/common/components/modulePageFilterBar.tsx +++ b/static/app/views/insights/common/components/modulePageFilterBar.tsx @@ -106,11 +106,15 @@ export function ModulePageFilterBar({ otherwise two clicks are required because of some rerendering/event propogation issues into the children */}
- - {!disableProjectFilter && } - - - + {/* Requires an extra div, else the pagefilterbar will grow to fill the height + of the readout ribbon which results in buttons being very large. */} +
+ + {!disableProjectFilter && } + + + +
{hasDataWithSelectedProjects && extraFilters} ); diff --git a/static/app/views/issueDetails/groupDetails.tsx b/static/app/views/issueDetails/groupDetails.tsx index 582c1c525298ff..34bbe67984205b 100644 --- a/static/app/views/issueDetails/groupDetails.tsx +++ b/static/app/views/issueDetails/groupDetails.tsx @@ -60,7 +60,7 @@ import { IssueDetailsTourContext, ORDERED_ISSUE_DETAILS_TOUR, } from 'sentry/views/issueDetails/issueDetailsTour'; -import SampleEventAlert from 'sentry/views/issueDetails/sampleEventAlert'; +import {SampleEventAlert} from 'sentry/views/issueDetails/sampleEventAlert'; import {GroupDetailsLayout} from 'sentry/views/issueDetails/streamline/groupDetailsLayout'; import {useIssueActivityDrawer} from 'sentry/views/issueDetails/streamline/hooks/useIssueActivityDrawer'; import {useMergedIssuesDrawer} from 'sentry/views/issueDetails/streamline/hooks/useMergedIssuesDrawer'; diff --git a/static/app/views/issueDetails/sampleEventAlert.tsx b/static/app/views/issueDetails/sampleEventAlert.tsx index 383264eebe3466..0e8057b0723871 100644 --- a/static/app/views/issueDetails/sampleEventAlert.tsx +++ b/static/app/views/issueDetails/sampleEventAlert.tsx @@ -1,15 +1,12 @@ -import styled from '@emotion/styled'; - +import {Alert} from 'sentry/components/core/alert'; import {LinkButton} from 'sentry/components/core/button/linkButton'; -import PageAlertBar from 'sentry/components/pageAlertBar'; import {IconLightning} from 'sentry/icons'; import {t} from 'sentry/locale'; -import {space} from 'sentry/styles/space'; import type {Organization} from 'sentry/types/organization'; import type {AvatarProject} from 'sentry/types/project'; import {trackAnalytics} from 'sentry/utils/analytics'; -function SampleEventAlert({ +export function SampleEventAlert({ organization, project, }: { @@ -17,35 +14,32 @@ function SampleEventAlert({ project: AvatarProject; }) { return ( - - - - {t( - 'You are viewing a sample error. Configure Sentry to start viewing real errors.' - )} - - - trackAnalytics('growth.sample_error_onboarding_link_clicked', { - project_id: project.id?.toString(), - organization, - platform: project.platform, - }) - } - > - {t('Get Started')} - - + } + trailingItems={ + + trackAnalytics('growth.sample_error_onboarding_link_clicked', { + project_id: project.id?.toString(), + organization, + platform: project.platform, + }) + } + > + {t('Get Started')} + + } + > + {t( + 'You are viewing a sample error. Configure Sentry to start viewing real errors.' + )} + ); } - -export default SampleEventAlert; - -const TextWrapper = styled('span')` - margin: 0 ${space(1)}; -`; diff --git a/static/app/views/issueDetails/streamline/header/header.tsx b/static/app/views/issueDetails/streamline/header/header.tsx index b977d016116a76..0e0e02f583348a 100644 --- a/static/app/views/issueDetails/streamline/header/header.tsx +++ b/static/app/views/issueDetails/streamline/header/header.tsx @@ -333,7 +333,7 @@ const WorkflowActions = styled('div')` const Workflow = styled('div')` display: flex; + align-items: center; gap: ${space(0.5)}; color: ${p => p.theme.subText}; - align-items: center; `; diff --git a/static/app/views/performance/transactionDetails/finishSetupAlert.tsx b/static/app/views/performance/transactionDetails/finishSetupAlert.tsx index 89302d1923ea34..40cc82842c1846 100644 --- a/static/app/views/performance/transactionDetails/finishSetupAlert.tsx +++ b/static/app/views/performance/transactionDetails/finishSetupAlert.tsx @@ -1,7 +1,7 @@ import styled from '@emotion/styled'; +import {Alert} from 'sentry/components/core/alert'; import {LinkButton} from 'sentry/components/core/button/linkButton'; -import PageAlertBar from 'sentry/components/pageAlertBar'; import {IconLightning} from 'sentry/icons'; import {t} from 'sentry/locale'; import {space} from 'sentry/styles/space'; @@ -16,28 +16,32 @@ export default function FinishSetupAlert({ projectId: string; }) { return ( - - + } + trailingItems={ + + trackAnalytics('growth.sample_transaction_docs_link_clicked', { + project_id: projectId, + organization, + }) + } + > + {t('Get Started')} + + } + > {t( 'You are viewing a sample transaction. Configure performance to start viewing real transactions.' )} - - trackAnalytics('growth.sample_transaction_docs_link_clicked', { - project_id: projectId, - organization, - }) - } - > - {t('Get Started')} - - + ); }