omp_init_lock() has undefined behavior if the lock is already init'ed @ ImageMagick#5360

Cristy · Cristy · commit fc4744f79987 · 2022-07-25T08:10:07.000-04:00
diff --git a/MagickCore/mutex.h b/MagickCore/mutex.h
@@ -55,7 +55,8 @@ static inline void DestroyMagickMutex(void)
 static inline void InitializeMagickMutex(void)
 {
 #if defined(MAGICKCORE_OPENMP_SUPPORT)
-  omp_init_lock(&translation_unit_mutex);
+  if (translation_unit_initialized == MagickFalse)
+    omp_init_lock(&translation_unit_mutex);
   translation_unit_initialized=MagickTrue;
 #endif
 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ static inline void DestroyMagickMutex(void)`
`55`	`55`	`static inline void InitializeMagickMutex(void)`
`56`	`56`	`{`
`57`	`57`	`#if defined(MAGICKCORE_OPENMP_SUPPORT)`
`58`		`- omp_init_lock(&translation_unit_mutex);`
	`58`	`+ if (translation_unit_initialized == MagickFalse)`
	`59`	`+ omp_init_lock(&translation_unit_mutex);`
`59`	`60`	`translation_unit_initialized=MagickTrue;`
`60`	`61`	`#endif`
`61`	`62`	`}`