Skip to content

repo sync #5638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 22, 2021
Merged

repo sync #5638

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5ddaafb
use wrapper from options instead of hardcoded div
sarahs Apr 21, 2021
6c51a6b
also pass the processed selector, not the original selector
sarahs Apr 21, 2021
ce37aae
use scope.environments instead of context in liquid tag rendering
sarahs Apr 22, 2021
56abbd2
Merge branch 'main' of github.com:github/docs-internal into restore-p…
sarahs Apr 22, 2021
7343b88
divs mess up the DOM and create empty <p> tags; use spans instead so …
sarahs Apr 22, 2021
cd9985d
Merge branch 'main' into restore-procedural-image-wrapper
sarahs Apr 22, 2021
b0bf54b
Merge branch 'main' into indented-data-ref-parsing
sarahs Apr 22, 2021
f7899d4
Merge branch 'main' into repo-sync
Octomerger Apr 22, 2021
92c8274
Merge pull request #18943 from github/repo-sync
Octomerger Apr 22, 2021
7a8cccf
Merge branch 'main' into indented-data-ref-parsing
sarahs Apr 22, 2021
7df8df4
Merge pull request #18937 from github/indented-data-ref-parsing
sarahs Apr 22, 2021
8ab292b
Merge branch 'main' into restore-procedural-image-wrapper
sarahs Apr 22, 2021
f69c0fd
Merge branch 'main' into repo-sync
Octomerger Apr 22, 2021
c616844
Merge pull request #18919 from github/restore-procedural-image-wrapper
sarahs Apr 22, 2021
3ab0e89
Branch was updated using the 'autoupdate branch' Actions workflow.
Octomerger Apr 22, 2021
1147407
Merge pull request #18944 from github/repo-sync
Octomerger Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use wrapper from options instead of hardcoded div
  • Loading branch information
@sarahs
sarahs committed Apr 21, 2021
commit 5ddaafb6ba180421f5bd96d41d4dccc9ead10374
6 changes: 3 additions & 3 deletions lib/render-content/plugins/wrap-in-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ module.exports = options => {

for (const match of selectAll(options.selector, tree)) {
visit(tree, match, (node, i, parent) => {
const wrapper = parseSelector('div')
wrapper.children = [node]
parent.children[i] = wrapper
const parsedWrapper = parseSelector(wrapper)
parsedWrapper.children = [node]
parent.children[i] = parsedWrapper
})
}
}
Expand Down