[jsweep] Clean assign_agent_helpers.cjs

[github-actions]

Summary

Cleaned actions/setup/js/assign_agent_helpers.cjs as part of the daily jsweep JavaScript unbloat process.

Context: github-script (uses global github, core, context)

---

Changes

assign_agent_helpers.cjs

Fix variable shadowing (bug fix)

• Renamed inner agentName → assigneeAgentName in the allowedAgents filter callback inside assignAgentToIssue. The inner variable was shadowing the outer agentName function parameter, which is a JavaScript anti-pattern that can lead to confusing bugs.

Simplify debug message building

• Replaced imperative string concatenation (let debugMsg = ...; if (x) debugMsg += ...) with a declarative array spread pattern, making the conditional parts clearer and more readable.

Property shorthand

• Used assignableId shorthand instead of assignableId: assignableId in the fallback mutation variables object.

assign_agent_helpers.test.cjs

Added 5 new tests for getPullRequestDetails

• getPullRequestDetails was exported and used by assign_to_agent.cjs but had zero test coverage.
• Added comprehensive tests: success case, null PR, empty assignees, GraphQL error re-throw, correct variables passed to GraphQL.

---

Test improvements

• Before: 35 tests
• After: 40 tests (+5 for getPullRequestDetails)

---

✅ Validation checks

• Formatting: npm run format:cjs ✓
• Linting: npm run lint:cjs ✓
• Type checking: npm run typecheck ✓
• Tests: 40/40 passed ✓

Generated by jsweep - JavaScript Unbloater · ◷

• expires on Mar 30, 2026, 4:37 AM UTC

---

Note

This was originally intended as a pull request, but PR creation failed. The changes have been pushed to the branch jsweep/assign-agent-helpers-7ada000fce058c24.

Original error: Validation Failed: {"resource":"Label","code":"unprocessable","field":"data","message":"Could not resolve to a node with the global id of 'PR_kwDOPc1QR87OOJzM'."}

To create the pull request manually:

gh pr create --title "[jsweep] Clean assign_agent_helpers.cjs" --base main --head jsweep/assign-agent-helpers-7ada000fce058c24 --repo github/gh-aw

Show patch preview (176 of 176 lines)

From 6240ff37c66e3edbb7c1b8da3ae5cfaba899324d Mon Sep 17 00:00:00 2001
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Sat, 28 Mar 2026 04:35:03 +0000
Subject: [PATCH] jsweep: clean assign_agent_helpers.cjs

- Fix variable shadowing: rename inner `agentName` to `assigneeAgentName`
  in the allowedAgents filter callback to avoid shadowing the outer parameter
- Simplify debug message building using array spread pattern instead of
  imperative string concatenation
- Use property shorthand in fallback mutation variables object
- Add 5 new tests for `getPullRequestDetails` (previously untested despite
  being exported and used in assign_to_agent.cjs)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 actions/setup/js/assign_agent_helpers.cjs     | 25 +++---
 .../setup/js/assign_agent_helpers.test.cjs    | 86 ++++++++++++++++++-
 2 files changed, 99 insertions(+), 12 deletions(-)

diff --git a/actions/setup/js/assign_agent_helpers.cjs b/actions/setup/js/assign_agent_helpers.cjs
index 1dd4005..5c7cdf1 100644
--- a/actions/setup/js/assign_agent_helpers.cjs
+++ b/actions/setup/js/assign_agent_helpers.cjs
@@ -262,10 +262,10 @@ async function assignAgentToIssue(assignableId, agentId, currentAssignees, agent
   if (allowedAgents && allowedAgents.length > 0) {
     filteredAssignees = currentAssignees.filter(assignee => {
       // Check if this assignee is a known agent
-      const agentName = getAgentName(assignee.login);
-      if (agentName) {
+      const assigneeAgentName = getAgentName(assignee.login);
+      if (assigneeAgentName) {
         // It's an agent - only keep if in allowed list
-        const isAllowed = allowedAgents.includes(agentName);
+        const isAllowed = allowedAgents.includes(assigneeAgentName);
         if (!isAllowed) {
           core.info(`Filtering out agent "${assignee.login}" (not in allowed list)`);
         }
@@ -361,13 +361,16 @@ async function assignAgentToIssue(assignableId, agen
... (truncated)

[pelikhan]

/q investigate when the pr creation failed

[github-actions]

🎩 Mission equipment ready! Q has optimized your workflow. Use wisely, 007! 🔫

[github-actions]

Pull request created: #23328

🎩 Equipped by Q