Skip to content

Conversation

@6543
Copy link
Member

@6543 6543 commented Apr 14, 2020

close #11006

@techknowlogick techknowlogick added type/bug modifies/api This PR adds API routes or modifies them labels Apr 14, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 14, 2020
@guillep2k guillep2k changed the title [BugFix] [API] /repos/{owner}/{repo}/contents/{filepath}: optinal branch [API] make branch parameter optional for /repos/{owner}/{repo}/contents/{filepath} Apr 15, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 15, 2020
@codecov-io
Copy link

codecov-io commented Apr 19, 2020

Codecov Report

Merging #11067 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11067      +/-   ##
==========================================
+ Coverage   43.22%   43.24%   +0.01%     
==========================================
  Files         601      601              
  Lines       85544    85553       +9     
==========================================
+ Hits        36980    37000      +20     
+ Misses      43999    43975      -24     
- Partials     4565     4578      +13     
Impacted Files Coverage Δ
routers/api/v1/repo/file.go 72.29% <100.00%> (+0.55%) ⬆️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 49.79% <0.00%> (-1.26%) ⬇️
services/pull/pull.go 33.39% <0.00%> (-0.77%) ⬇️
modules/notification/webhook/webhook.go 39.61% <0.00%> (-0.59%) ⬇️
models/issue.go 51.48% <0.00%> (-0.47%) ⬇️
models/pull.go 52.19% <0.00%> (+0.77%) ⬆️
services/pull/check.go 55.48% <0.00%> (+17.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77171ab...06763d9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2020
@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit b9ed8d8 into go-gitea:master Apr 20, 2020
@zeripath zeripath changed the title [API] make branch parameter optional for /repos/{owner}/{repo}/contents/{filepath} Make branch parameter optional for /api/v1/repos/{owner}/{repo}/contents/{filepath} Apr 20, 2020
@lafriks lafriks deleted the fix-api_11006_optional-branch branch April 20, 2020 17:08
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] /repos/{owner}/{repo}/contents/{filepath}: optinal branch

6 participants