cmd: dump: check value of skip-repository flag #11254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a boolean flag; simply checking if it's set isn't enough, we must check the value as well.
techknowlogick
approved these changes
Apr 30, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
the
type/refactoring
zeripath
approved these changes
Apr 30, 2020
guillep2k
approved these changes
May 2, 2020
GiteaBot
added
lgtm/done
guillep2k
added
skip-changelog
lunny
approved these changes
May 2, 2020
Member
|
Ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
This is a boolean flag; simply checking if it's set isn't enough, we must check the value as well. Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a boolean flag; simply checking if it's set isn't enough, we must
check the value as well.