Fix NPE in due to missing signing key on commit page #11392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go template's `{{if ...}}` does not shortcut its tests therefore it is
possible to cause a NPE unless you separate ifs into two.
Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
approved these changes
May 12, 2020
Member
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
does not shortcut its tests
uhhh.. this seems not good, but I guess if it is a language choice then there it could be a breaking change for them to update it.
GiteaBot
added
the
lgtm/need 1
adelowo
approved these changes
May 12, 2020
GiteaBot
added
lgtm/done
Member
|
Very weird though. |
Member
zeripath
changed the title
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Go template's `{{if ...}}` does not shortcut its tests therefore it is
possible to cause a NPE unless you separate ifs into two.
Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go template's
{{if ...}}does not shortcut its tests therefore it ispossible to cause a NPE unless you separate ifs into two.
Fix #11230
Signed-off-by: Andrew Thornton [email protected]