Default MSSQL port 0 to allow automatic detection by default #11642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#11633 Signed-off-by: Andrew Thornton <[email protected]>
CirnoT
approved these changes
May 27, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
May 27, 2020
GiteaBot
added
lgtm/done
Contributor
Author
|
this probably needs a backport to 1.12 too |
Member
|
ping LG-TM |
Member
|
@zeripath please send backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 29, 2020
…a#11642) Backport go-gitea#11642 Fix go-gitea#11633 Signed-off-by: Andrew Thornton <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
May 29, 2020
…#11673) Backport #11642 Fix #11633 Signed-off-by: Andrew Thornton <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…a#11642) Fix go-gitea#11633 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #11633 setting the default port to 1433 prevents automatic detection by default - which although appropriate in many environments - is not expected by most users of MSSQL. Setting the port to be "0" allows automatic detection by default.
(Marked as bug because I think it conflicts so much with expected behaviour.)
Fix #11633
Signed-off-by: Andrew Thornton [email protected]