Skip to content

Adds a checkbox to select all issues/PRs #20177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 28, 2022
Merged

Adds a checkbox to select all issues/PRs #20177

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c22d07d
Add select all checkbox function
tyroneyeh Jun 30, 2022
732a690
Fix lint problem
tyroneyeh Jun 30, 2022
f9c2e5a
Remove a variable defined
tyroneyeh Jun 30, 2022
62e9f31
Remove config name to storage global variable
tyroneyeh Jul 4, 2022
c29bb79
split checkbox click event function
tyroneyeh Jul 4, 2022
82a3985
Update web_src/js/features/common-issue.js
tyroneyeh Jul 5, 2022
d9659db
Update web_src/js/features/common-issue.js
tyroneyeh Jul 5, 2022
25fa1d8
Adjust global variable to private
tyroneyeh Jul 5, 2022
f326510
Fix lint issue
tyroneyeh Jul 5, 2022
e29f542
Add permission condition for checkbox select all
tyroneyeh Jul 8, 2022
942bf9f
Update templates/repo/issue/list.tmpl
tyroneyeh Jul 9, 2022
5d9fb50
Remove range select function
tyroneyeh Jul 9, 2022
03b37ce
Merge branch 'main' into 18883_bulk_selected_issues
tyroneyeh Jul 17, 2022
0e53de3
Merge branch 'main' into 18883_bulk_selected_issues
tyroneyeh Jul 19, 2022
59c3e46
Merge branch 'main' into 18883_bulk_selected_issues
tyroneyeh Jul 20, 2022
01f3f0f
Remove invert selection func
tyroneyeh Jul 28, 2022
456da24
refactor
wxiaoguang Jul 28, 2022
95608a2
make checkbox "vertical-align: middle"
wxiaoguang Jul 28, 2022
cad540d
Merge branch 'main' into 18883_bulk_selected_issues
wxiaoguang Jul 28, 2022
5437afb
Merge branch 'main' into 18883_bulk_selected_issues
wxiaoguang Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint problem
  • Loading branch information
@tyroneyeh
tyroneyeh committed Jun 30, 2022
commit 732a690c0c7df84829281abdc4921a33fd9a0b30
14 changes: 7 additions & 7 deletions web_src/js/features/common-issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function initCommonIssue() {
$('.issue-checkbox,.issue-checkbox-all').on('click', (e) => {
const issuecheckbox = $('.issue-checkbox input');
let allcheckbox;
if (e.currentTarget.className.indexOf('issue-checkbox-all') !== -1) {
if (e.currentTarget.className.includes('issue-checkbox-all')) {
allcheckbox = $('.issue-checkbox-all input');
if (allcheckbox.prop('checked')) {
const selected = $('.issue-checkbox input:checked');
Expand All @@ -15,22 +15,22 @@ export function initCommonIssue() {
$('.issue-checkbox input:checked').prop('checked', 0);
}
}
if (e.shiftKey && config.checkboxfirst !== undefined) {
for (let i = config.checkboxfirst + 1, j = issuecheckbox.index($(e.currentTarget).find('input')); i < j; i++) {
if (e.shiftKey && window.config.checkboxfirst !== undefined) {
for (let i = window.config.checkboxfirst + 1, j = issuecheckbox.index($(e.currentTarget).find('input')); i < j; i++) {
issuecheckbox[i].checked = 1;
}
delete config.checkboxfirst;
delete window.config.checkboxfirst;
} else {
config.checkboxfirst = issuecheckbox.index($(e.currentTarget).find('input'));
window.config.checkboxfirst = issuecheckbox.index($(e.currentTarget).find('input'));
}
if (issuecheckbox.is(':checked')) {
$('#issue-filters').addClass('hide');
$('#issue-actions').removeClass('hide');
$('#issue-actions .six').prepend($('.issue-checkbox-all'))
$('#issue-actions .six').prepend($('.issue-checkbox-all'));
} else {
$('#issue-filters').removeClass('hide');
$('#issue-actions').addClass('hide');
$('#issue-filters .six').prepend($('.issue-checkbox-all'))
$('#issue-filters .six').prepend($('.issue-checkbox-all'));
}
});

Expand Down