Skip to content

Commit a263d0f

Browse files
committed
Add more logging of errors
1 parent 87fa139 commit a263d0f

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

connection.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ func (mc *mysqlConn) Exec(query string, args []driver.Value) (driver.Result, err
359359
// try to interpolate the parameters to save extra roundtrips for preparing and closing a statement
360360
prepared, err := mc.interpolateParams(query, args)
361361
if err != nil {
362+
mc.log(err.Error())
362363
return nil, err
363364
}
364365
query = prepared
@@ -369,6 +370,7 @@ func (mc *mysqlConn) Exec(query string, args []driver.Value) (driver.Result, err
369370
copied := mc.result
370371
return &copied, err
371372
}
373+
mc.log(err.Error())
372374
return nil, mc.markBadConn(err)
373375
}
374376

@@ -377,23 +379,27 @@ func (mc *mysqlConn) exec(query string) error {
377379
handleOk := mc.clearResult()
378380
// Send command
379381
if err := mc.writeCommandPacketStr(comQuery, query); err != nil {
382+
mc.log(err.Error())
380383
return mc.markBadConn(err)
381384
}
382385

383386
// Read Result
384387
resLen, _, err := handleOk.readResultSetHeaderPacket()
385388
if err != nil {
389+
mc.log(err.Error())
386390
return err
387391
}
388392

389393
if resLen > 0 {
390394
// columns
391395
if err := mc.skipColumns(resLen); err != nil {
396+
mc.log(err.Error())
392397
return err
393398
}
394399

395400
// rows
396401
if err := mc.skipRows(); err != nil {
402+
mc.log(err.Error())
397403
return err
398404
}
399405
}
@@ -418,20 +424,23 @@ func (mc *mysqlConn) query(query string, args []driver.Value) (*textRows, error)
418424
// try client-side prepare to reduce roundtrip
419425
prepared, err := mc.interpolateParams(query, args)
420426
if err != nil {
427+
mc.log(err.Error())
421428
return nil, err
422429
}
423430
query = prepared
424431
}
425432
// Send command
426433
err := mc.writeCommandPacketStr(comQuery, query)
427434
if err != nil {
435+
mc.log(err.Error())
428436
return nil, mc.markBadConn(err)
429437
}
430438

431439
// Read Result
432440
var resLen int
433441
resLen, _, err = handleOk.readResultSetHeaderPacket()
434442
if err != nil {
443+
mc.log(err.Error())
435444
return nil, err
436445
}
437446

@@ -505,7 +514,6 @@ func (mc *mysqlConn) finish() {
505514

506515
// Ping implements driver.Pinger interface
507516
func (mc *mysqlConn) Ping(ctx context.Context) (err error) {
508-
mc.log("Ping mysql connection")
509517
if mc.closed.Load() {
510518
return driver.ErrBadConn
511519
}
@@ -572,10 +580,12 @@ func (mc *mysqlConn) QueryContext(ctx context.Context, query string, args []driv
572580
func (mc *mysqlConn) ExecContext(ctx context.Context, query string, args []driver.NamedValue) (driver.Result, error) {
573581
dargs, err := namedValueToValue(args)
574582
if err != nil {
583+
mc.log(err.Error())
575584
return nil, err
576585
}
577586

578587
if err := mc.watchCancel(ctx); err != nil {
588+
mc.log(err.Error())
579589
return nil, err
580590
}
581591
defer mc.finish()

0 commit comments

Comments
 (0)