Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/oauth2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.0
Choose a base ref
...
head repository: golang/oauth2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.21.0
Choose a head ref
  • 8 commits
  • 16 files changed
  • 7 contributors

Commits on Mar 11, 2024

  1. appengine: drop obsolete code for AppEngine envs <=Go 1.11

    This library no longer builds on Go versions prior to Go 1.17,
    so no longer needs to support compilation specific to AppEngine
    environments on Go versions prior to Go 1.11
    
    Related to #615
    
    Change-Id: Ia9579ea2091cb86ee96065affb920370c4ba33ea
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570595
    Reviewed-by: Matt Hickford <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Cody Oss <[email protected]>
    Run-TryBot: Matt Hickford <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    liggitt authored and hickford committed Mar 11, 2024
    1 Configuration menu
    Copy the full SHA
    3a6776a View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. oauth2/google: fix remove content-type header from idms get requests

    This is a fix on the googleapis/google-cloud-go#9508.
    The aws provider in that library is a ported dependency from here.
    
    Change-Id: I28e1efa4fdb8292210b695a164a55060c83dae88
    GitHub-Last-Rev: c425f2d
    GitHub-Pull-Request: #711
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570875
    Reviewed-by: Cody Oss <[email protected]>
    Reviewed-by: Chris Smith <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    BigTailWolf authored and codyoss committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5a05c65 View commit details
    Browse the repository at this point in the history
  2. oauth2/google: fix the logic of sts 0 value of expires_in

    The sts response contains an optional field of `expires_in` and the value can be any integer.
    
    https://github.com/golang/oauth2/blob/master/google/internal/externalaccount/basecredentials.go#L246-L248
    
    In the case of less than `0`, we are going to throw an error. But in the case of equals to `0` practically it means "never expire" instead of "instantly expire" which doesn't make sense.
    
    So we need to not set the expiration value for Token object. The current else if greater or equal is wrong.
    
    It's never triggered only because we are sending positive `3600` in sts response.
    
    Change-Id: Id227ca71130855235572b65ab178681e80d0da3a
    GitHub-Last-Rev: a95c923
    GitHub-Pull-Request: #687
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/545895
    Reviewed-by: Shin Fan <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Cody Oss <[email protected]>
    Reviewed-by: Cody Oss <[email protected]>
    BigTailWolf authored and gopherbot committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3c9c1f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. google: add Credentials.UniverseDomainProvider

    * move MDS universe retrieval within Compute credentials
    
    Change-Id: I847d2075ca11bde998a06220307626e902230c23
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/575936
    Reviewed-by: Cody Oss <[email protected]>
    Auto-Submit: Cody Oss <[email protected]>
    Run-TryBot: Cody Oss <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    quartzmo authored and gopherbot committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d0e617c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. microsoft: added DeviceAuthURL to AzureADEndpoint

    The Microsoft identity platform supports the device authorization grant:
    
    https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code
    
    This PR adds the "https://login.microsoftonline.com/{tenant}/oauth2/v2.0/devicecode" DeviceAuthURL to the AzureADEndpoint.
    
    Fixes #700
    
    Change-Id: I8ca571391e0e0f4d383e3f2f07a66b26edcb4679
    GitHub-Last-Rev: 2b953c3
    GitHub-Pull-Request: #701
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/564315
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Matt Hickford <[email protected]>
    Run-TryBot: Matt Hickford <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    enrichman authored and hickford committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e11eea8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. go.mod: update cloud.google.com/go/compute/metadata dependency

    Related #615
    Related googleapis/google-cloud-go#9545
    
    Change-Id: I762dc53c61204ec5103336dab6358b9b4d1337d4
    GitHub-Last-Rev: 439c393
    GitHub-Pull-Request: #719
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/579495
    Reviewed-by: Cody Oss <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Cody Oss <[email protected]>
    Reviewed-by: Jordan Liggitt <[email protected]>
    sagikazarmark authored and codyoss committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4b7f0bd View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. oauth2: fix typo in comment

    Change-Id: Ifc12ed36671d21e388c537c510a82be084e9ec99
    GitHub-Last-Rev: a4da759
    GitHub-Pull-Request: #720
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/580715
    TryBot-Bypass: Cody Oss <[email protected]>
    Reviewed-by: Cody Oss <[email protected]>
    Reviewed-by: Joedian Reid <[email protected]>
    testwill authored and codyoss committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    84cb9f7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. google: update compute token refresh

    The shortest MDS token cache time is 4 minutes. The refresh window is updated
    to 3 minutes and 45 seconds to give the MDS time to update it's cache.
    
    This should make slow refreshes less likely to cause failures.
    
    Done in googleapis/google-cloud-go#9139 for the other auth library.
    
    Change-Id: Ifa353248197d8998e6b0363d1f2821b45a0e6495
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/584815
    Auto-Submit: Cody Oss <[email protected]>
    TryBot-Bypass: Cody Oss <[email protected]>
    Run-TryBot: Cody Oss <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Cody Oss <[email protected]>
    clundin25 authored and gopherbot committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5fd4241 View commit details
    Browse the repository at this point in the history
Loading