Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.0
Choose a base ref
...
head repository: golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.0
Choose a head ref
  • 13 commits
  • 10 files changed
  • 10 contributors

Commits on Jul 16, 2024

  1. LICENSE: update per Google Legal

    Very minor tweaks:
     - Remove (c) pseudosymbol.
     - Remove "All Rights Reserved."
     - Change "Google Inc." (no longer exists) to "Google LLC".
    
    [git-generate]
    echo '
    ,s/\(c\) //
    ,s/ All rights reserved.//
    ,s/Google Inc./Google LLC/
    w
    q
    ' | sam -d LICENSE
    
    Change-Id: Ifc1b84adca131018a48ba47e741a682a0ed9bb49
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/598584
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    rsc authored and gopherbot committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    411f99e View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. README: don't recommend go get

    These days people will just import the packages and the go tool will
    do the right thing. We don't need to explain it.
    
    Add a pointer to the git repo, though.
    
    For golang/go#62645
    
    Change-Id: Icbe33e05f96e1b32f6fcc99fb5fb0b2ecb213a08
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/623820
    Commit-Queue: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Alan Donovan <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    ianlancetaylor authored and gopherbot committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    151027e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. singleflight: fix typo in singleflight_test.go

    Change-Id: Ia2160fdc8f1938d784a4e1595151c00bc521f5c3
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/626795
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Run-TryBot: Emmanuel Odeke <[email protected]>
    Commit-Queue: Ian Lance Taylor <[email protected]>
    Reviewed-by: Emmanuel Odeke <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Emmanuel Odeke <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Alan Donovan <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    catatsuy authored and gopherbot committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    913fb63 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2025

  1. sync/errgroup: improve documentation for semaphore limit behavior

    Updated the documentation for `SetLimit` and `Go` functions in the
    `errgroup` package. the note clarifies the behavior when the semaphore
    limit is set to zero, which could lead to a deadlock if not handled
    properly. the updated documentation warns users to set a positive
    semaphore limit to avoid blocking goroutines and potential deadlock
    
    this change improves the clarity of API and helps users understand how
    to properly use the semaphore limit to prevent issues in concurrent
    execution
    
    Change-Id: Ie62acc38ef804b3590c04bddba00a3cce21e8cef
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/642215
    Reviewed-by: Michael Knyszek <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    berbreik authored and gopherbot committed Jan 17, 2025
    Configuration menu
    Copy the full SHA
    fe3591b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. all: upgrade go directive to at least 1.23.0 [generated]

    By now Go 1.24.0 has been released, and Go 1.22 is no longer supported
    per the Go Release Policy (https://go.dev/doc/devel/release#policy).
    
    For golang/go#69095.
    
    [git-generate]
    (cd . && go get [email protected] && go mod tidy && go fix ./... && go mod edit -toolchain=none)
    
    Change-Id: I7e3b1e073a0a64e82e2b9e49387d5da0afd9d58b
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/649835
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    960bf1f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2025

  1. errgroup: drop support for Go versions before 1.20

    Change-Id: I7de5dfae21c4ffe31d6c16e3df0fed3e2269cb16
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/654421
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Commit-Queue: Ian Lance Taylor <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    ianlancetaylor authored and gopherbot committed Mar 4, 2025
    Configuration menu
    Copy the full SHA
    b637f27 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2025

  1. errgroup: document calling Go before Wait

    Fixes golang/go#70284
    
    Change-Id: I31d60ea182226c032b0ffbddcbb5b53675dfd5e6
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/660075
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Alan Donovan <[email protected]>
    Auto-Submit: Damien Neil <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    seankhliao authored and gopherbot committed Apr 2, 2025
    Configuration menu
    Copy the full SHA
    396f3a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2025

  1. errgroup: propagate panic and Goexit through Wait

    Recovered panic values are wrapped and saved in Group.
    Goexits are detected by a sentinel value set after the given function
    returns normally. Wait propagates the first instance of a panic or
    Goexit.
    
    According to the runtime.Goexit after the code will not be executed,
    with a bool, if f not call runtime.Goexit, is true,
    determine whether to propagate runtime.Goexit.
    
    Fixes golang/go#53757
    
    Change-Id: Ic6426fc014fd1c4368ebaceef5b0d6163770a099
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/644575
    Reviewed-by: Sean Liao <[email protected]>
    Auto-Submit: Alan Donovan <[email protected]>
    Commit-Queue: Alan Donovan <[email protected]>
    Reviewed-by: Alan Donovan <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    qiulaidongfeng authored and gopherbot committed Apr 7, 2025
    Configuration menu
    Copy the full SHA
    506c70f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2025

  1. sync/errgroup: PanicError.Error print stack trace

    Because it is useful to print the stack
    when a nil pointer dereference occurs.
    
    Fixes golang/go#73710
    
    Change-Id: I106ea0bdd70c2a293f5ea889edef9b5ba9db2fbd
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/672635
    Reviewed-by: Damien Neil <[email protected]>
    Auto-Submit: Damien Neil <[email protected]>
    Auto-Submit: Alan Donovan <[email protected]>
    Reviewed-by: Alan Donovan <[email protected]>
    TryBot-Bypass: Damien Neil <[email protected]>
    qiulaidongfeng authored and gopherbot committed May 14, 2025
    Configuration menu
    Copy the full SHA
    d1ac909 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2025

  1. all: replace deprecated ioutil

    Change-Id: I1beb9f5e759127a48c4e5ea0613a5a466886b7c5
    GitHub-Last-Rev: 58038b6
    GitHub-Pull-Request: #28
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/674815
    Reviewed-by: Alan Donovan <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Sean Liao <[email protected]>
    Auto-Submit: Alan Donovan <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    12ya authored and gopherbot committed May 24, 2025
    Configuration menu
    Copy the full SHA
    1869c69 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2025

  1. errgroup: remove duplicated comment

    Change-Id: I5cdcc5034ccd87b939a406693e97485553ab60fa
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/676715
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Alan Donovan <[email protected]>
    Auto-Submit: Alan Donovan <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    xieyuschen authored and gopherbot committed May 28, 2025
    Configuration menu
    Copy the full SHA
    8a14946 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2025

  1. errgroup: revert propagation of panics

    This change reverts CL 644575, which caused panics in the f()
    call after group.Go(f) to be propagated to the subsequent
    group.Wait call. This caused more problems than it solved.
    
    Also:
    - preserve some of the doc comment wording of Group.Go.
    - leave a "tsunami stone" comment in Group.Go.
    
    Fixes golang/go#53757
    Updates golang/go#74275
    Updates golang/go#74304
    Updates golang/go#74306
    
    Change-Id: I6e3992510944db7d69c72eaf241aedf8b84e62dd
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/682935
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: qiu laidongfeng2 <[email protected]>
    Reviewed-by: Junyang Shao <[email protected]>
    Reviewed-by: Sean Liao <[email protected]>
    Auto-Submit: Sean Liao <[email protected]>
    adonovan authored and gopherbot committed Jun 20, 2025
    Configuration menu
    Copy the full SHA
    7fad2c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2025

  1. all: upgrade go directive to at least 1.24.0 [generated]

    By now Go 1.25.0 has been released, and Go 1.23 is no longer supported
    per the Go Release Policy (see https://go.dev/doc/devel/release#policy).
    
    For golang/go#69095.
    
    [git-generate]
    (cd . && go get [email protected] && go mod tidy && go fix ./... && go mod edit -toolchain=none)
    
    Change-Id: Ifa2b9ecc1efe475dfe4d60f41fb3ad2c63896d12
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/695358
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    gopherbot committed Aug 13, 2025
    Configuration menu
    Copy the full SHA
    04914c2 View commit details
    Browse the repository at this point in the history
Loading