Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sys
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.0
Choose a base ref
...
head repository: golang/sys
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.0
Choose a head ref
  • 18 commits
  • 41 files changed
  • 10 contributors

Commits on Jan 5, 2023

  1. unix: add //go:build line to gccgo_c.c

    Change-Id: I425df52458cc53afb986a260a41d0b638bd5e6e8
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/460157
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Auto-Submit: Tobias Klauser <[email protected]>
    Run-TryBot: Tobias Klauser <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    tklauser authored and gopherbot committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1e9f341 View commit details
    Browse the repository at this point in the history
  2. cpu: add //go:build line to cpu_gccgo_x86.c

    Change-Id: I597a83c767bf597f4d5c2ffdd7097f3cd6781f84
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/460158
    Auto-Submit: Tobias Klauser <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Tobias Klauser <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    tklauser authored and gopherbot committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b8be2fd View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. unix/linux: update to Linux kernel 6.1 and Go 1.20-rc2

    Change-Id: Iaff9781793b2896aba6d4788faf0d5dde18c1395
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/461297
    Run-TryBot: Tobias Klauser <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Benny Siegert <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Tobias Klauser <[email protected]>
    tklauser authored and gopherbot committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6e4d1c5 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. windows: use UTF16FromString and UTF16ToString from syscall

    This CL updates the windows.UTF16FromString and windows.UTF16ToString
    implementation so they forward to their syscall counterparts.
    
    The standard library uses these particular syscall functions across
    the board as it can't depend on x/sys. This means that even if the
    syscall API is frozen, the implementation still receives improvements
    and bug fixes, such as CL 425054.
    
    Porting CL 425054 to x/sys is possible, but for this particular case
    I think it's better to just call the syscall package. This way both
    repos will benefit from future improvements (which I plan to do soon).
    
    Change-Id: I305c4409142d79a57008d7e6d0717fb8986fe906
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/462875
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Quim Muntal <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    qmuntal authored and gopherbot committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    a6f4650 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. unix: avoid false positive in vet shift check

    A uint64 >> 64 is reported as a mistake by the vet shift check.
    This is arguably a bug in vet, but we can't fix the old releases,
    so work around it.
    
    Works around golang/go#58030.
    
    Change-Id: Ic6b9ee2eb4bf01c77d9f7fcedb35562f733fce60
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/463675
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Russ Cox <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    rsc committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    17fce3a View commit details
    Browse the repository at this point in the history
  2. cpu: add IsBigEndian

    Copy the definition of x/sys/unix.isBigEndian to x/sys/cpu.
    
    Updates golang/go#57237
    
    Change-Id: Iefbf4303720445611de93b0a3ea365f8208c033b
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/463335
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    Run-TryBot: Tobias Klauser <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Rob Pike <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    tklauser committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    13fe000 View commit details
    Browse the repository at this point in the history
  3. unix: add support for clock_adjtime on Linux

    This provides a ClockAdjtime function providing access to the clock_adjtime system call on Linux.
    The clock_adjtime system call is like adjtimex, but takes a clockid_t as its first argument.
    The unix package already provides Adjtimex and the associated Timex struct; it also provides
    the other functions that take a clockid_t (like ClockGettime). ClockAdjtime is an essential
    system call for programs that want to use the Linux PTP hardware clock infrastructure (see
    https://docs.kernel.org/driver-api/ptp.html).
    
    Fixes golang/go#57618
    
    Change-Id: I68d022425eb9cd394a204ad7fedab985c0496fee
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/463056
    Reviewed-by: Tobias Klauser <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Tobias Klauser <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    jclark authored and gopherbot committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c3037ed View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. unix/linux: update to gcc 13.0.0, qemu 7.1.0 for loong64

    No changes in generated files.
    
    Update loongarch64-linux-gcc to 13.0.0
    - The kernel header file version is upgraded to 5.19
    
    Update qemu-loongarch64 to 7.1.0
    - Support for LoongArch has been merged upstream.
    
    Change-Id: I637925fd9e5575dfb4ce91ece98951d5bf3053e6
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/453458
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: xiaodong liu <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    abner-chenc authored and gopherbot committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    b829a39 View commit details
    Browse the repository at this point in the history
  2. windows/mkwinsyscall: support "." and "-" in DLL name

    This change adds "." and "-" support for DLL filenames in "//sys".
    
    Supporting "." requires a change in how mkwinsyscall handles the
    "= <filename>.<function>" syntax. Instead of assuming that only one "."
    can appear in this string, now mkwinsyscall assumes that any additional
    "." belongs to the filename.
    
    Supporting "." also requires changing how Go identifiers are created for
    each DLL. This change also allows mkwinsyscall to support "-". When
    creating a Go identifier, "." and "-" in the DLL filename are replaced
    with "_". Otherwise, mkwinsyscall would produce invalid Go code, causing
    "format.Source" to fail.
    
    Includes a test for the new behavior. There aren't yet any cases where
    this code is executed while generating the x/sys/windows syscalls. The
    syscalls "SetSocketMediaStreamingMode" from "windows.networking.dll" and
    "WslRegisterDistribution" from "api-ms-win-wsl-api-l1-1-0.dll" can be
    successfully called using this change, but these syscalls have no known
    use in Go so they are not included in this change.
    
    Fixes golang/go#57913
    
    Change-Id: If64deeb8c7738d61520e7392fd2d81ef8920f08d
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/463215
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Alex Brainman <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    Run-TryBot: Alex Brainman <[email protected]>
    Reviewed-by: Quim Muntal <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    dagood authored and alexbrainman committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    71da690 View commit details
    Browse the repository at this point in the history
  3. windows/mkwinsyscall: write source to temp file if formatting fails

    This change writes the unformatted Go source code to a temp file if
    "format.Source" fails. Print the temp file path to the console to make
    it easy to find. The source code is what causes formatting errors, and
    it can be difficult to diagnose them without this context.
    
    Fixes golang/go#57925
    
    Change-Id: Ifa4d8a6e8bc5006357b0bc88afce5ba1d6fe0a48
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/463216
    Reviewed-by: Michael Knyszek <[email protected]>
    Reviewed-by: Alex Brainman <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    Reviewed-by: Quim Muntal <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    dagood authored and gopherbot committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    4112509 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. unix/linux: update to glibc 2.36

    Support for LoongArch has been merged upstream. This allows to
    drop the loong64 specific glibc patches.
    
    Because the header file sys/mount.h of glibc 2.36 includes fcntl.h
    (commit 78a408ee7ba041fc8d5dbd5f67065b4a982c11e5), this will leads to
    duplicate definition of structure stat on MIPS64.  In order to solve
    this error, use the custom type my_stat to generate the Go Stat_t.
    
    Change-Id: I888280d777d1c7089548acf1b3821762011d79b0
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/453555
    Reviewed-by: xiaodong liu <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    abner-chenc authored and gopherbot committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    7a75290 View commit details
    Browse the repository at this point in the history
  2. all: fix some comments

    Change-Id: I7d5bfd4caac63820b26fc3408118c13e74e6448c
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/464238
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Tobias Klauser <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Tobias Klauser <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    cuishuang authored and gopherbot committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e7d7f63 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. unix: improve flaky solaris test logging

    relates to golang/go#58259
    
    Change-Id: I47bbf4afb59b6e98571297ba53d7f9370712e030
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/465015
    Reviewed-by: Bryan Mills <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    nshalman authored and gopherbot committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    01b330b View commit details
    Browse the repository at this point in the history
  2. unix: add missing constants used with struct Timex on Linux

    This provides definitions for Linux of two groups of constants,
    which are used with struct Timex (used with the adjtimex and
    clock_adjtime system calls): the ADJ_* constants are used
    for the modes field; the STA_* constants are used for the status
    field. The constants are documented in the adjtimex(2) man page.
    
    Fixes golang/go#58012
    
    Change-Id: I054f0c40f9cfd9360a0bb10716a08e19584c0fff
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/464241
    Run-TryBot: Tobias Klauser <[email protected]>
    Reviewed-by: Tobias Klauser <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Auto-Submit: Tobias Klauser <[email protected]>
    jclark authored and gopherbot committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    6938dae View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. unix: add ptrace(PT_DENY_ATTACH) wrapper for darwin

    Change-Id: I13e4426e6e411ceb449539479d9bcee15a518cf6
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/464655
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Tobias Klauser <[email protected]>
    tmthrgd authored and gopherbot committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    0e1262c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. windows/debug/svc: buffer channel passed to signal.Notify

    The os/signal package drops signal notifications if the channel is not
    ready to receive immediately. To avoid dropping signals (for example,
    while processing the other branch of a 'select'), the channel must be
    buffered.
    
    This fixes a mistake flagged by 'go vet ./...'.
    
    Change-Id: I2a20dbe2aa27ae8ec009fff5e7be47e4409fdddd
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/465595
    Auto-Submit: Bryan Mills <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    Reviewed-by: Quim Muntal <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Bryan C. Mills authored and gopherbot committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    68f9dcb View commit details
    Browse the repository at this point in the history
  2. unix: add missing address operator in initxattrdest

    The purpose of the _zero variable is to provide a valid address for a
    pointer to an array of length zero. All other uses of the variable
    take its address, but one reference to it (added in CL 147850043)
    converts the variable (which has type uintptr) directly to an
    unsafe.Pointer, producing a nil pointer instead of a non-nil pointer
    to a zero-length array.
    
    This typo is caught by 'go vet', but was masked for a long time by the
    numerous false-positive warnings for the same check (#41205).
    
    For golang/go#41205.
    
    Change-Id: Ib3bebfadc6fc5574db19630169ff3f65da857bdd
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/465597
    Reviewed-by: David Chase <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Tobias Klauser <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    Bryan C. Mills authored and gopherbot committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4e121b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. unix: avoid converting non-pointers to unsafe.Pointer in PtraceIO

    Despite having the misleading type "void*" in the C API, the "offs"
    field of the ptrace_io_desc struct is an offset within the child
    process, and thus is not necessarily a valid pointer at all in the
    parent process. The Go unsafe.Pointer type must refer only to valid
    pointers, so converting this field through unsafe.Pointer is incorrect
    and (in some cases) dangerous.
    
    While we're here, let's also rename the "addr" function argument to
    "offs", since that's the corresponding ptrace_io_desc field. It's very
    confusing to have a function argument named "attr" that doesn't map to
    the struct field of the same name!
    
    For golang/go#58351.
    
    Change-Id: Id899f823e8d398b51fb0c42f466d7ae2f957c26b
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/465675
    Run-TryBot: Bryan Mills <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Bryan C. Mills authored and gopherbot committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    90c8f94 View commit details
    Browse the repository at this point in the history
Loading