Skip to content

Commit 74353ab

Browse files
committed
remove spaces from notebook names because they break pytest parsing
1 parent 74f529e commit 74353ab

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Contributing to Notebooks
22

3+
## Notebook Naming
4+
5+
Notebooks cannot have spaces in the paths. Use underscores instead. This is
6+
because pytest does not like spaces in command line arguments.
7+
38
## Docker Image Validation
49

510
The docker image must be able to run all notebooks. Whenever a change is made to

jupyter-notebooks/getting-to-know-sat-imagery/Inspecting Satellite Imagery.ipynb renamed to jupyter-notebooks/getting-to-know-sat-imagery/Inspecting_Satellite_Imagery.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@
420420
"name": "python",
421421
"nbconvert_exporter": "python",
422422
"pygments_lexer": "ipython3",
423-
"version": "3.6.5"
423+
"version": "3.6.6"
424424
}
425425
},
426426
"nbformat": 4,

jupyter-notebooks/getting-to-know-sat-imagery/Visualizing Satellite Imagery.ipynb renamed to jupyter-notebooks/getting-to-know-sat-imagery/Visualizing_Satellite_Imagery.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@
169169
"name": "python",
170170
"nbconvert_exporter": "python",
171171
"pygments_lexer": "ipython3",
172-
"version": "3.6.5"
172+
"version": "3.6.6"
173173
}
174174
},
175175
"nbformat": 4,

0 commit comments

Comments
 (0)