feat: Support custom port for no-localhost login#1104
Conversation
Add support for the `--redirect-port` option when using `clasp login --no-localhost`. Previously, the serverless (no-localhost) flow hardcoded the redirect URI to port 8888. Now, it respects the provided port, defaulting to 8888 if not specified. - Update `ServerlessAuthorizationCodeFlow` to accept a `port` argument. - Update `authorize` to pass `redirectPort` to `ServerlessAuthorizationCodeFlow`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Add support for the `--redirect-port` option when using `clasp login --no-localhost`. Previously, the serverless (no-localhost) flow hardcoded the redirect URI to port 8888. Now, it respects the provided port, defaulting to 8888 if not specified. - Update `ServerlessAuthorizationCodeFlow` to accept a `port` argument. - Update `authorize` to pass `redirectPort` to `ServerlessAuthorizationCodeFlow`. - Fix `validateOptionInt` to return parsed integer instead of string.
vinay-google
changed the title
1 participant
Add support for custom port when using
clasp login --no-localhost. This allows users to match the redirect URI registered in their OAuth client if it differs from the default port 8888.Closes #1103
PR created automatically by Jules for task 20776023153713785