Skip to content

Add Client method #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Add Client method #2016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e708608
Add Client method
gmlewis Jul 20, 2021
9a0e1df
Add test for coverage
gmlewis Jul 20, 2021
6867ee3
Address review feedback to eliminate race condition
gmlewis Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review feedback to eliminate race condition
  • Loading branch information
@gmlewis
gmlewis committed Jul 21, 2021
commit 6867ee340521a06a8caa519d8907543fb579f0d4
3 changes: 2 additions & 1 deletion github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ type service struct {
func (c *Client) Client() *http.Client {
c.clientMu.Lock()
defer c.clientMu.Unlock()
return c.client
clientCopy := *c.client
return &clientCopy
}

// ListOptions specifies the optional parameters to various List methods that
Expand Down
4 changes: 2 additions & 2 deletions github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ func TestNewClient(t *testing.T) {
func TestClient(t *testing.T) {
c := NewClient(nil)
c2 := c.Client()
if c.client != c2 {
t.Error("Client returned different http.Client, but should be the same.")
if c.client == c2 {
t.Error("Client returned same http.Client, but should be different")
}
}

Expand Down