Skip to content

Fix UriTemplate.expand to properly escape value #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2018
Merged

Fix UriTemplate.expand to properly escape value #534

merged 3 commits into from
Dec 10, 2018

Conversation

@ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Dec 4, 2018

Fixes #351 UriTemplate.expand does not properly escape characters for path-style parameter expansion

  • Tests pass
  • Appropriate docs were updated (if necessary)

@ajaaym ajaaym requested a review from a team as a code owner December 4, 2018 22:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2018
@chingor13 chingor13 merged commit d16ab5c into googleapis:master Dec 10, 2018
This was referenced Jan 3, 2019
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajaaym @chingor13 @googlebot