Skip to content

fix: correct connect timeout setting for ApacheHttpRequest #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 4, 2019
Merged

fix: correct connect timeout setting for ApacheHttpRequest #803

merged 7 commits into from
Sep 4, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Aug 28, 2019

Fixes #799

@chingor13 chingor13 requested a review from a team as a code owner August 28, 2019 16:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
elharo
elharo reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@chingor13
Copy link
Contributor Author

chingor13 commented Aug 28, 2019

Same comment as in #804: The Apache HttpClient implementation does a great job and making itself uninspectable once initialized - we would need to test its behavior (or use reflection to look at internals).

For these transport adapters, we will need to set up an integration test that somehow ensures the desired behavior.

elharo
elharo reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one initially seemed harder to test, but I think @chanseokoh had a really good idea in the bug report that will enable us to test this one by setting a low timeout and connecting to a non-existent site.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2019
@chingor13
Copy link
Contributor Author

chingor13 commented Sep 3, 2019

I'm not sure why this fails on windows, but it seems to be within the Apache adapter. We should be able to skip this test on windows.

@chingor13 chingor13 requested review from a team and elharo September 3, 2019 16:25
elharo
elharo reviewed Sep 3, 2019
View reviewed changes
...nt-apache-v2/src/test/java/com/google/api/client/http/apache/v2/ApacheHttpTransportTest.java

@Test(timeout = 10_000L)
public void testConnectTimeout() {
// Apache HttpClient doesn't appear to behave correctly on windows
Copy link
Contributor

@elharo elharo Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a bug filed against Apache we could reference here?

@chingor13 chingor13 merged commit df21ebc into googleapis:master Sep 4, 2019
@chingor13 chingor13 deleted the apache-connection-timeout branch September 4, 2019 15:33
@chingor13 chingor13 mentioned this pull request Sep 11, 2019
Merged
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@eaball35
chore: update doclet version (googleapis#803)
c2e565f 
Same as googleapis/java-shared-config#368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elharo elharo elharo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: connection timeout ignored in 1.31.0 while works in 1.27.0

4 participants

@chingor13 @elharo @googlebot @kokoro-team