Skip to content

Commit b9196cf

Browse files
authored
feat: Add grpc.xds.resource_type label to xDS client metrics (#13358)
This is a quick fix to add the missing grpc.xds.resource_type label in xds_client metrics (b/451687047).
1 parent b0f1362 commit b9196cf

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

spanner/metrics.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ const (
6868
metricLabelKeyDirectPathUsed = "directpath_used"
6969
metricLabelKeyGRPCLBPickResult = "grpc.lb.pick_result"
7070
metricLabelKeyGRPCLBDataPlaneTarget = "grpc.lb.rls.data_plane_target"
71+
metricLabelKeyGRPCXDSResourceType = "grpc.xds.resource_type"
7172

7273
// Metric names
7374
metricNameOperationLatencies = "operation_latencies"

spanner/metrics_monitoring_exporter.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ var (
6666
allowedMetricLabels = map[string]bool{
6767
metricLabelKeyGRPCLBPickResult: true,
6868
metricLabelKeyGRPCLBDataPlaneTarget: true,
69+
metricLabelKeyGRPCXDSResourceType: true,
6970
metricLabelKeyClientUID: true,
7071
metricLabelKeyClientName: true,
7172
metricLabelKeyDatabase: true,

0 commit comments

Comments
 (0)