Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Mar 21, 2019

Fixes #618

  • Tests pass
  • Appropriate docs were updated (if necessary)

This module came in for the first time in 1.28.0for unclear reasons as part of the now reverted split of the apache classes out of the main artifact (#543). I'm proposing removing it as part of the revert of that split.

@elharo elharo requested a review from a team as a code owner March 21, 2019 13:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2019
@sduskis
Copy link
Contributor

sduskis commented Mar 25, 2019

Wouldn't this be a backwards incompatible change?

@elharo
Copy link
Contributor Author

elharo commented Mar 25, 2019

If we released a new version that changed the signatures that would be incompatible. This is simply not releasing a new version.

@sduskis sduskis requested review from chingor13 and removed request for a team March 26, 2019 16:57
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 28, 2019
@chingor13
Copy link
Contributor

Closed in favor of #637

@chingor13 chingor13 closed this May 15, 2019
@chingor13 chingor13 deleted the i618 branch September 5, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Apache Http Client in 1.29.0?

6 participants