Skip to content

fix: OpenCensus spans should close on IOExceptions #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 28, 2019
Merged

fix: OpenCensus spans should close on IOExceptions #797

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f9ae0d8
chore: add basic test for OpenCensus spans
chingor13 Aug 19, 2019
f758535
chore: add failing test for closing spans on IOExceptions
chingor13 Aug 19, 2019
0763216
fix: close SENT span if the IOException was not handled before rethro…
chingor13 Aug 19, 2019
7d5ee76
relax curl logger tests for added opencensus header
chingor13 Aug 28, 2019
b06a0db
fix: address PR comments
chingor13 Aug 28, 2019
ae89bc0
chore: remove unused helper
chingor13 Aug 28, 2019
855db7c
fix: dependency warning for opencensus-impl
chingor13 Aug 28, 2019
7e2f2c7
chore: cleanup PR comments
chingor13 Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove unused helper
  • Loading branch information
@chingor13
chingor13 committed Aug 28, 2019
commit ae89bc066b2aeced27d4c5e4000811a2cf5aa74d
7 changes: 0 additions & 7 deletions google-http-client/src/main/java/com/google/api/client/http/OpenCensusUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,6 @@ public static EndSpanOptions getEndSpanOptions(@Nullable Integer statusCode) {
return builder.build();
}

static EndSpanOptions getEndSpanOptionsForResponse(@Nullable HttpResponse response) {
if (response != null) {
return getEndSpanOptions(response.getStatusCode());
}
return getEndSpanOptions(null);
}

/**
* Records a new message event which contains the size of the request content. Note that the size
* represents the message size in application layer, i.e., content-length.
Expand Down