Skip to content

Commit f5bed57

Browse files
committed
feat(opentelemetry): add request_tag to span attributes
1 parent db90a47 commit f5bed57

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

google/cloud/spanner_v1/_helpers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,16 @@
3535
from google.cloud.spanner_v1.data_types import JsonObject, Interval
3636
from google.cloud.spanner_v1.request_id_header import with_request_id
3737
from google.cloud.spanner_v1.types import TypeCode
38-
from opentelemetry.semconv.resource import ResourceAttributes
39-
from opentelemetry.resourcedetector.gcp_resource_detector import (
40-
GoogleCloudResourceDetector,
41-
)
4238

4339
from google.rpc.error_details_pb2 import RetryInfo
4440

4541
try:
4642
from opentelemetry.propagate import inject
4743
from opentelemetry.propagators.textmap import Setter
44+
from opentelemetry.semconv.resource import ResourceAttributes
45+
from opentelemetry.resourcedetector.gcp_resource_detector import (
46+
GoogleCloudResourceDetector,
47+
)
4848

4949
HAS_OPENTELEMETRY_INSTALLED = True
5050
except ImportError:

tests/system/test_session_api.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ def _make_attributes(db_instance, **kwargs):
354354
"db.url": "spanner.googleapis.com",
355355
"net.host.name": "spanner.googleapis.com",
356356
"db.instance": db_instance,
357+
"cloud.region": "global",
357358
"gcp.client.service": "spanner",
358359
"gcp.client.version": ot_helpers.LIB_VERSION,
359360
"gcp.client.repo": "googleapis/python-spanner",

0 commit comments

Comments
 (0)