report: hide 3rd party filter checkbox if all rows are 3rd party #8966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jburger424
changed the title
patrickhulce
changed the title
patrickhulce
approved these changes
May 15, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM thanks @jburger424!
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
can you add a test to report-ui-features-test.js? It should hopefully only need picking another audit from the sample results in that beforeAll section and make them all third party
Contributor
|
and actually, that "no filter" test is just for |
brendankenny
approved these changes
May 17, 2019
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Resolves #8955