Skip to content

Conversation

@patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented May 16, 2019

Summary
Our trace minification logic got out of sync with some of our lantern improvements of the past few months. This PR fixes that, refactors it to a lib, and adds some tests while we're at it so it won't get out of sync again.

Related Issues/PRs
closes #8949

@brendankenny
Copy link
Contributor

sorry to be lazy, but could you add some comments about which files moved where vs what's new? :D:D

@brendankenny
Copy link
Contributor

jk, that might be too lazy. This is two moved files and two new test files :)

Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small things and questions

There's probably an argument for moving them into some sub directory in lib/, but also seems fine enough there :)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert minify-trace to library code

3 participants