deps: remove commitizen as local dep #9246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
also, also, the knock-on dependency changes are kind of crazy |
paulirish
approved these changes
Jun 21, 2019
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
works for me. i use it occasionally but w/e. not a big deal.
patrickhulce
approved these changes
Jun 21, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
WFM, I tend to end up editing the message on GH anyhoo
Contributor
Author
|
just to be clear, I'm pretty sure everything still works as before (with a global I don't want to make people who use |
| resolved "https://registry.yarnpkg.com/fill-range/-/fill-range-2.2.4.tgz#eb1e773abb056dcd8df2bfdf6af59b8b3a936565" | ||
| integrity sha512-cnrcCbj01+j2gTG921VZPnHbjmdAf8oQV/iGeV2kZxGSyfYjjTyY79ErsK1WJWMpw6DaApEX72binqJE+/d+5Q== | ||
| dependencies: | ||
| is-number "^2.1.0" |
Contributor
Author
There was a problem hiding this comment.
If anyone is worried about our deps getting too skinny, we still have another fill-range and two versions of is-number in here :)
connorjclark
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a security vulnerability in a transitive dep of commitizen which doesn't currently have a fixed version.
Buuuut, I don't think anyone here actually uses commitizen? And even if they do, all the docs I can find instruct that it should be installed globally, and we don't provide an npm script to access the version in node_modules, so not sure why we have it in here anyways.
If anyone does use it when writing commits, that use case isn't broken since
cz-customizableand thepackage.jsonconfig entry are still around, so will work as is if you havecommitizeninstalled globally.(also,
yarn changelogisn't affected by this ascommitizenis only the writing side of things andconventional-changelogdoesn't depend on it to read commit messages)