tests: improve drag-and-drop coverage #9314
Conversation
Remexllee
changed the title
Remexllee
changed the title
Remexllee
changed the title
Remexllee
changed the title
patrickhulce
changed the title
patrickhulce
changed the title
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
looks great thanks so much for taking this up @Remexllee!
|
|
||
| function assertUIReset() { | ||
| assert.ok(!document.querySelector('.drop_zone').classList.contains('dropping')); | ||
| function createCustomEvent(type, key, value) { |
There was a problem hiding this comment.
nit: WDYT about the caller passing {key: value} to make it a little clearer below
There was a problem hiding this comment.
do you mean add a comment here?
There was a problem hiding this comment.
let's ignore this comment in favor of #9314 (comment)
| expect(mockCallback).toBeCalledWith('mock file'); | ||
| }); | ||
|
|
||
| it('document responds to drop event without file', () => { |
There was a problem hiding this comment.
| it('document responds to drop event without file', () => { | |
| it('document ignores drop event without file', () => { |
There was a problem hiding this comment.
will fix it. thanks for suggestion.
| assert.ok(!document.querySelector('.drop_zone').classList.contains('dropping')); | ||
| function createCustomEvent(type, key, value) { | ||
| const customDropEvent = new window.CustomEvent(type); | ||
| if (key && value) { |
There was a problem hiding this comment.
right now it's a bit odd that the callers do createCustomEvent('drag', 'dataTransfer', null) when it seems like that doesn't really do anything, is this intentional?
There was a problem hiding this comment.
I think removing this fn entirely would be better.
// create custom drop event with mock files in dataTransfer
const event = new CustomEvent('drop');
event.dataTransfer = {
files: ['mock file'],
};
document.dispatchEvent(event);
There was a problem hiding this comment.
Oh yeah ignore what I was saying, let's go with @connorjclark !
| it('document responds to mouseleave event when not dragging', () => { | ||
| new DragAndDrop(jest.fn); | ||
|
|
||
| document.dispatchEvent(new window.CustomEvent('mouseleave')); |
There was a problem hiding this comment.
should we align on createCustomEvent while we're at it?
There was a problem hiding this comment.
true, I will made the change align it
4 participants
Summary
I fixed the unit test in drag-and-drop-test.js file
This is a refactoring of unit test
Related Issues/PRs