tests(font-size): assert on source #9413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
feels like we need to do some virtual jumping jacks to atone for our 😈
🤸♂ 🤸♂ 🤸♂ 🤸♂ 🤸♂ 🤸♂ 🤸♂
| attributes: ['size', '10px'], | ||
| }); | ||
|
|
||
| expect(auditResult.details.items[0].source).toBe('http://www.example.com'); |
Collaborator
There was a problem hiding this comment.
it's also funny because the whole reason I recommended toMatchObject in the first place was because you were asserting against .source and .selector separately 😆
| describe('attributes style source', () => { | ||
| async function runFontSizeAuditWithSingleFailingStyle(style, nodeProperties) { | ||
| const artifacts = { | ||
| URL: {finalUrl: 'http://www.example.com'}, |
connorjclark
commented
Jul 19, 2019
| }); | ||
|
|
||
| describe('attributes source location', () => { | ||
| describe('attributes style source', () => { |
Collaborator
Author
There was a problem hiding this comment.
attributes style source are all nouns so.... wb attributes source of style ? still all nouns but BAM a preposition too
Collaborator
Author
🤸♂️ 🤸♂️ done |
exterkamp
approved these changes
Jul 23, 2019
Member
exterkamp
left a comment
exterkamp
left a comment
There was a problem hiding this comment.
LGTM, nice job breaking out the PRs into little ones!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cont. #9400