core(font-size): gather style declaration of type Attributes

[connorjclark]

Attributes is a type for cssRule in the font-size artifact.

The audit checks for it here.

However, the gatherer never returned a rule of type Attributes. Instead, it was returning no cssRule (that property is optional) - which was fine because the audit handles it in the same way.

First thought was to just remove Attributes from the type property. But then I saw it was pretty simple to change the gatherer to be correct.

But ... it doesn't really convey much more information - just makes it more explicit - so I could go either way with this. The style declaration will look like this:

{ type: 'Attributes',
  range: undefined,
  styleSheetId: undefined,
  parentRule: undefined }

Also: I think this was the only reason cssRule was made optional - or is there another valid reason that it would not exist?

[patrickhulce]

I suppose this LGTM!

Definitely a bit weird that the font-size audit result is identical whether we identify the style source or not, maybe that should change :)

[patrickhulce]

want to throw attributesStyle in here to test the correct specificity?

[connorjclark]

done

[connorjclark]

Definitely a bit weird that the font-size audit result is identical whether we identify the style source or not, maybe that should change :)

In either the Inline or Attributes case, we want to point to the node in the audit table. I'm not sure if doing anything special in Attributes (like annotating the result in the table with <font size=1> (attributes)) is ideal.

also font (the only way Attributes will happen here) is sooooo old should we care about making it look different?

[patrickhulce]

also font (the only way Attributes will happen here) is sooooo old should we care about making it look different?

fair points, I'm sold :)

[exterkamp]

LGTM!

[brendankenny]

LGTM