tests(smokehouse): index for static server. print address #9541
Conversation
connorjclark
requested review from
brendankenny and
patrickhulce
as code owners
| {resourceType: 'script', requestCount: 3, size: '55000±1000'}, | ||
| {resourceType: 'image', requestCount: 2, size: '28000±1000'}, | ||
| {resourceType: 'document', requestCount: 1, size: '2100±100'}, | ||
| {resourceType: 'document', requestCount: 1, size: '2200±100'}, |
There was a problem hiding this comment.
went up b/c content-type header is now added for html docs
There was a problem hiding this comment.
oh right that's easy to forget that header cost is included in these
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
surprised it took us this long to do this, what a waste of memorizing these paths! 😆
| } else if (filePath.endsWith('.json')) { | ||
| headers['Content-Type'] = 'application/json'; | ||
| } else if (filePath.endsWith('.html') || filePath === '/') { | ||
| headers['Content-Type'] = 'text/html'; |
There was a problem hiding this comment.
this feels 100% unrelated to the index part, right?
why cause conflicts for yourself in #9542 :)
| const fixturePaths = glob.sync('**/*.html', {cwd: __dirname}); | ||
| const html = ` | ||
| <h1>Smoke test fixtures</h1> | ||
| ${fixturePaths.map(p => `<a href=${p}>${p}</a>`).join('<br>')} |
There was a problem hiding this comment.
does this work on windows, like are the paths returned by glob different?
do we care if it doesn't? probably not
| serverForOnline.listen(onlinePort, 'localhost'); | ||
| serverForOffline.listen(offlinePort, 'localhost'); | ||
| console.log(`online: listening on http://localhost:${onlinePort}`); | ||
| console.log(`offline: listening on http://localhost:${offlinePort}`); |
There was a problem hiding this comment.
there's really nothing offline or online about these, it's just how we use them for one(?) of the smoke tests (we also use them for same- and different-origin in other tests), but I'm not sure it matters what we call them :)
Co-Authored-By: Patrick Hulce <[email protected]>
5 participants
Minor enhancement.