core(i18n): throw on excess placeholder replacement values #9580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Aug 20, 2019
| const expectedPathId = 'lighthouse-core/test/lib/i18n/fake-file-number-2.js | aString'; | ||
| expect(icuMessagePaths).toEqual({ | ||
| [templateID]: [{path: 'audits[fake-audit].title', values: {x: 1}}]}); | ||
| [expectedPathId]: [{path: 'audits[fake-audit].title', values: {x: 1}}]}); |
Contributor
Author
There was a problem hiding this comment.
dangers of singletons :) this test was implicitly relying on the test above having called createMessageInstanceIdFn
patrickhulce
approved these changes
Aug 20, 2019
| sirNotAppearingInThisString: 66, | ||
| }); | ||
| expect(_ => i18n.getFormatted(helloStr, 'en-US')) | ||
| // eslint-disable-next-line max-len |
Collaborator
There was a problem hiding this comment.
apparently we've decided there's disagreement on this point so we should never use disable-next-line max-len again :P
@exterkamp I'm gonna love this convo next week where I can learn how splitting is possibly better 😆
Collaborator
|
some unit tests are still unhappy about spanish locale swap though |
brendankenny
force-pushed
the
messageextravals
branch
from
db8cb07 to
9103f12
Compare
Contributor
Author
|
ok, with #9598 in, the tests for this should now all pass 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a check that all arguments in an ICU message have values passed into our i18n functions; this PR adds a check that all the values passed in have a place to be used in the ICU message. This is useful when strings change since we have no type checking that our localized strings match the values being passed in for replacement.
I was originally going to include this in #9570, but ran into a ton of errors in our unit tests. Turns out this is just because
LHErroralways includeserrorCodein the replacement values so you don't have to write'NO_FCP'three times just to get aNO_FCPerror. I added a comment to remind the next person abouterrorCode.This condition currently only happens in one place (the change in #9486 removing
itemCount), but removingitemCountreveals a flaw in our system: if the ICU arguments in a string aren't provided invalues, we throw an error (and if we don't throw one,intl-messageformatdoes). This is an issue when the other locale files have strings with different ICU arguments than the en-US one does (as is currently case forthird-party-summary.js | displayValue).This is a pretty fundamental issue so going to fix that before landing this :)