report: don't use unnessary monospace #9626
Conversation
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
also needs fixture update I believe
| const headings = [ | ||
| {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)}, | ||
| {key: 'description', itemType: 'code', text: str_(UIStrings.columnDesc)}, | ||
| {key: 'description', itemType: 'text', text: str_(UIStrings.columnDesc)}, |
There was a problem hiding this comment.
I think I'd prefer to keep this one as code since in my experience these are less wall of text than deprecation explanations, but I don't feel terribly strongly.
There was a problem hiding this comment.
yeah, I probably agree with this (and monospace matches how it's displayed in the devtools console), but without auto code markdown for the symbols in each of these, display won't be ideal, mono or not
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
also needs an update:sample-json
| const headings = [ | ||
| {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)}, | ||
| {key: 'description', itemType: 'code', text: str_(UIStrings.columnDesc)}, | ||
| {key: 'description', itemType: 'text', text: str_(UIStrings.columnDesc)}, |
There was a problem hiding this comment.
yeah, I probably agree with this (and monospace matches how it's displayed in the devtools console), but without auto code markdown for the symbols in each of these, display won't be ideal, mono or not
|
|
5 participants
we shouldn't render sentences or paragraphs in monospace. not very readable.
before
after
