misc: timings script #9723
misc: timings script #9723
Conversation
lighthouse-core/scripts/timings.js
Outdated
| .array('urls') | ||
| .string('lh-flags') | ||
| .default('lh-flags', '') | ||
| // Why is the printing for examples so awful? |
There was a problem hiding this comment.
Anyone know how to make yargs examples output not look terrible?
There was a problem hiding this comment.
We're still on ancient yargs so I'm sure it's been fixed in a version released in the past 5 years :)
lighthouse-core/scripts/timings.js
Outdated
| .array('urls') | ||
| .string('lh-flags') | ||
| .default('lh-flags', '') | ||
| // Why is the printing for examples so awful? |
There was a problem hiding this comment.
We're still on ancient yargs so I'm sure it's been fixed in a version released in the past 5 years :)
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
this is really handy. Do we want a more descriptive name for the script? I don't have a good suggestion, though
lighthouse-core/scripts/timings.js
Outdated
| /** @type {LH.Result} */ | ||
| const lhr = JSON.parse(lhrJson); | ||
|
|
||
| for (const measureName of lhr.timing.entries.map(entry => entry.name)) { |
There was a problem hiding this comment.
nit: it might make sense to s/measure/timing for a lot of these names, to avoid splitting the nomenclature from timing/Execution timings/timingEntries we use for the values in all of the core files. Not a huge deal, but it does make it harder to remember in this file that there are accumulations of lhr.timing entries
There was a problem hiding this comment.
gave it a shot
|
|
SGTM |
| function summarize() { | ||
| // `${url}@@@${entry.name}` -> duration | ||
| /** @type {Map<string, number[]>} */ | ||
| const durationsMap = new Map(); |
There was a problem hiding this comment.
not sure this is better. Now we have timing, measure, and duration :)
4 participants
For example usages, see #9712 and #9713