Skip to content

misc: support unset variables in lhci dogfood script #9745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paulirish merged 1 commit into from
Sep 27, 2019
Merged

misc: support unset variables in lhci dogfood script #9745

paulirish merged 1 commit into from
Sep 27, 2019

Conversation

@patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Sep 26, 2019

Summary
We can't fail on unrecognized variables and check for them at the same time :)

brendankenny
brendankenny approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓🔍

@paulirish paulirish merged commit b650789 into master Sep 27, 2019
@paulirish paulirish deleted the fix_dogfood_ci branch September 27, 2019 00:09
paulirish pushed a commit that referenced this pull request Nov 6, 2019
@patrickhulce @paulirish
misc: support unset variables in lhci dogfood script (#9745)
b118cf7
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brendankenny brendankenny brendankenny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@patrickhulce @brendankenny @paulirish @googlebot