core: rename Element to LHElement #9832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
patrickhulce
approved these changes
Oct 14, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM
I'd say we could be more descriptive like DriverProxyElement or just ProxyElement something since I had to stare at this for a bit to remember why we have something called Element at all, but not required :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking out the ts 3.7 beta, this typing mistake became apparent. We use the global
Elementtype declaration (dom lib) where we really want ourlib/element.js. Renaming toLHElementis a simple solution to this name clash.the error was uncovered likely thanks to changes required for this bugfix: https://devblogs.microsoft.com/typescript/announcing-typescript-3-7-beta/ "Local and Imported Type Declarations Now Conflict"